Flakes: Shutdown vttablet before mysqld in backup tests #14647
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In general, it's best to shutdown a tablet before its mysqld instance. This ensures that the tablet can perform any shutdown related steps that may affect its mysqld instance.
The existing backup tests were NOT doing that, and the re-use of the MySQL instances could cause some unpredictable behavior.
This PR simply reverses the order of process termination in these tests.
Related Issue(s)
Checklist