Slack vitess r14.0.5 dsdefense throttle only if lag #14702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
* docs: added to the release notes Signed-off-by: Andres Taylor <andres@planetscale.com> * Add name to static check workflow Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>
…vitessio#10471) (vitessio#10474) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
…0453) (vitessio#10466) * fix: change planner_version to planner-version everywhere Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: actually change the planner version on vtgate after checking Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: move CheckPlannerVersionFlag out from vtgate Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: move the global plannerVersion to be a field on the executor. think global, act local, yo Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: use the planner in the session first Signed-off-by: Andres Taylor <andres@planetscale.com> * test: use DEFAULT instead of 0 Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: re-add the planner-version flag to vtcombo Signed-off-by: Andres Taylor <andres@planetscale.com>
* Add PingTablet to mock vtctld Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for PingTablet Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for RefreshState Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for RefreshTabletReplicationSource Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add RunHealthCheck to mock vtctld Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for RunHealthCheck Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for SetReadOnly Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for SetReadWrite Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for StartReplication Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for StopReplication Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for TabletExternallyPromoted Signed-off-by: Andrew Mason <andrew@planetscale.com>
* add sharding column name/type deprecation to release notes summary Signed-off-by: deepthi <deepthi@planetscale.com> * deprecation: mark sharding-column-name and sharding-column-type for CreateKeyspace command as deprecated Signed-off-by: deepthi <deepthi@planetscale.com>
* [vtadmin] Add authz tests for remaining non-schema related actions (vitessio#10481) * Add authz tests for EmergencyFailoverShard Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for PlannedFailoverShard Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add ValidateKeyspace to mock vtctld Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for ValidateKeyspace Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add ValidateSchemaKeyspace to mock vtctld Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for ValidateSchemaKeyspace Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add ValidateVersionKeyspace to mock vtctld Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for ValidateVersionKeyspace Signed-off-by: Andrew Mason <andrew@planetscale.com> * fixup mock data sorting Signed-off-by: Andrew Mason <andrew@planetscale.com> * [vtadmin] Add schema-related authz tests (vitessio#10486) * Update template to support more tablet fields Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update template, add full srvvschema payload, add schema payload, add authz tests for VTExplain Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for GetSchema Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for GetSchemas Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for FindSchema Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for ReloadSchemas Signed-off-by: Andrew Mason <andrew@planetscale.com>
…io#10502) (vitessio#10509) * Update docs for backup commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for cell commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for keyspace commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for legacy-shim command Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs, add aliases for reparent commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for root command Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for routing rule commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for schema commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for serving graph commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for shard commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for tablet commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for vschema commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for workflow commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Remove references to deprecated flags Signed-off-by: Andrew Mason <andrew@planetscale.com> * fixup! Update docs for keyspace commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Remove reparent command aliases Signed-off-by: Andrew Mason <andrew@planetscale.com> * Specify that `--server` is required Signed-off-by: Andrew Mason <andrew@planetscale.com>
… and move it to places which will only be called less frequently (vitessio#10516) (vitessio#10518) Signed-off-by: Manan Gupta <manan@planetscale.com>
… and vitessio#10514 (vitessio#10517) * Fix parsing of CAST() statements (vitessio#10512) * Fix parsing of CAST() statements CAST() was treated as an alias for CONVERT() but with slightly different syntax. This is also described in the documentation at https://dev.mysql.com/doc/refman/8.0/en/cast-functions.html, specifically: With CAST(expr AS type syntax, the CAST() function takes an expression of any type and produces a result value of the specified type. This operation may also be expressed as CONVERT(expr, type), which is equivalent. If expr is NULL, CAST() returns NULL. This is wrong sadly. CAST() is not equivalent to CONVERT(), specifically in the context of a CREATE TABLE. For JSON keys, the ARRAY attribute is possible on a CAST(), but that is not accepted for a CONVERT(). The difference in parsing also shows in MySQL: ``` mysql> select convert(json_keys(c), char(64) array) from t; ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'array) from t' at line 1 mysql> select cast(json_keys(c) as char(64) array) from t; ERROR 1235 (42000): This version of MySQL doesn't yet support 'Use of CAST( .. AS .. ARRAY) outside of functional index in CREATE(non-SELECT)/ALTER TABLE or in general expressions' ``` Here the first statement can't be parsed at all. The second is properly parsed, but ARRAY is not allowed in the context of CAST() in this situation (and only in a CREATE TABLE). This means we should really treat these as two separate expressions and don't store them both in the same structure. The change here creates a separate CAST structure, removes the ARRAY option from CONVERT and updates the grammar and all tests accordingly. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Handle new cast expression in evalengine and planbuilder Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * evalengine: do not duplicate CAST/CONVERT translation Signed-off-by: Vicent Marti <vmg@strn.cat> Co-authored-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Manan Gupta <manan@planetscale.com> * Add back unary single column expression check (vitessio#10514) This was accidentally removed in vitessio#10512 but it shouldn't have been. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Vicent Marti <vmg@strn.cat>
…0538) (vitessio#10540) Signed-off-by: Andrew Mason <andrew@planetscale.com>
…#10508) (vitessio#10528) * addition of the release_notes_label workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * addition of a helper step in the release_notes_label to guide users Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * addition of a set of rules for release_notes_labels's pull_request target Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * remove the previous workflow that used to check the release notes labels Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Change the review check list and enforce the use of type/component labels Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fixed syntax in check release notes label workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
…o#10484) Signed-off-by: Andrew Mason <andrew@planetscale.com>
…#10532) * generate the release changelog as a second document Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * include every PR in the release notes Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Moved changelog metrics away from the changelog and added summary for v15 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
…0553) * test: added failing e2e test Signed-off-by: Harshit Gangal <harshit@planetscale.com> * fix: handle empty row for scalar aggregation and also olap engine for scalar aggregation Signed-off-by: Harshit Gangal <harshit@planetscale.com> * test: update plan test output Signed-off-by: Harshit Gangal <harshit@planetscale.com> * test: e2e test for empty rows in non-scalar aggregates Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
* docs: add blurb about gen4 being the new planner Signed-off-by: Andres Taylor <andres@planetscale.com> * docs: release notes Signed-off-by: Andres Taylor <andres@planetscale.com>
…tessio#10480) (vitessio#10554) Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…itessio#10464) (vitessio#10546) * Adds RPCs to vttablet that vtorc requires (vitessio#10464) * feat: add vttablet rpc to reset replication parameters Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: added end to end testing for the rpc and fixed bug Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix typing error Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add basic full status rpc functionality and add test for it Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add all the fields needed in full status Signed-off-by: Manan Gupta <manan@planetscale.com> * test: moved the test to reparent tests and improved it Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: bug fix for no replication status and no primary status Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add version to the full status output Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add binlog information to full status Signed-off-by: Manan Gupta <manan@planetscale.com> * docs: fix the comment explaining the binlog information Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add semi-sync statuses to full status Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: call the correct command Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add server uuid and id to full status Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: make server_id a uint32 to accept the correct range of values Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add few more fields to the full status like version comment, semi-sync settings, binlog_row_image Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: generate vtadmin proto files Signed-off-by: Manan Gupta <manan@planetscale.com> * test: add assertion to check binlog row format is read correctly Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: split GTID mode in its own function because mariadb doesn't support it Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix parsing of empty mariadb gtid set Signed-off-by: Manan Gupta <manan@planetscale.com> * docs: add doucmentation for existing fields in ReplicationStatus Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add relay log file position to the replication status output Signed-off-by: Manan Gupta <manan@planetscale.com> * test: augmented full status test to check all the different positions stored Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add additional fields to replication status and read source user Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: read sql delay from show replica status output Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: read ssl allowed from show replica status output Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: read has replication filters from show replica status output Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: read auto position and using gtid from show replica status output Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add replication lag unknown too to replication status Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: return nils from replication and primary postiion if it is not present Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: rename FileRelayLogPosition in replication status output to RelayLogSourceBinLogEquivalentPosition and augment test to make sure rpc changes are backward compatible Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: update vtadmin proto files Signed-off-by: Manan Gupta <manan@planetscale.com> * refactor: rename BinLog to binlog in renamed proto field Signed-off-by: Manan Gupta <manan@planetscale.com> * lint: add a new line to proto file Signed-off-by: Manan Gupta <manan@planetscale.com>
…io#10562) * VReplication: more unrecoverable error codes Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * correct path for test files Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
* test: reproduce the panic as a unit test Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: check ev is not nil before using its fields Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: increase timeout of LockShard and wait replicas in VTOrc default config Signed-off-by: Manan Gupta <manan@planetscale.com>
…#10535) (vitessio#10570) The canonical form of printing the vitess migration syntax would upcase the UUID value, but it needs to be passed through unchanged. This in turn led me to testing comments in a query as well and it turns out we wrongly change the case there as well. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
…sist and unrecoverable errors (vitessio#10573) * Fail VReplication workflows on errors that persist and unrecoverable errors (vitessio#10429) * Fail workflow if same error persists too long. Fail for unrecoverable errors also in non-online ddl workflows Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Update max time default to 15m, was 1m for testing purposes Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Leverage vterrors for Equals; attempt to address my own nits Signed-off-by: Matt Lord <mattalord@gmail.com> * sanity: validate range of vreplication_retry_delay and of vreplication_max_time_to_retry_on_error Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Fix flags test Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Remove leftover log.Flush() Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Revert validations min/max settings on retry delay since it is breaking unit tests that set the value to a very small value Signed-off-by: Rohit Nayak <rohit@planetscale.com> * captilize per request Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * fix TestHelpOutput Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * spaces, not tabs Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Rohit Nayak <57520317+rohit-nayak-ps@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com>
…sts (vitessio#10522) * Take into account `github.ref` when doing upgrade-downgrade tests (vitessio#10504) * Take into account the github.ref variable when doing upgrade-downgrade tests Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Changed upgrade-downgrade workflows' syntax to use 'previous' instead of 'latest' Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fixed syntax error in backup upgrade downgrade workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fixed static_checks_etc workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
…hannel might block the vstream thread if target channel goes away: context was not being checked then. Fix health stream goroutine leak. (vitessio#10576) Signed-off-by: Rohit Nayak <rohit@planetscale.com>
* add-vtadmin-docker-image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * env as function, update tests and code Signed-off-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * feat: fix remaining env usages to be function calls Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * add vtadmin build result in the bootstrap image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * fix vtadmin web cleaning Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * add vtadmin docker image entrypoint Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * add the possibility to custom vtadmin web port in Docker image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * fix vtadmin docker port Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * fix vtadmin entrypoint Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * set default vtadmin docker user as vitess Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * do not build vtadmin frontend in the bootstrap image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * build vtadmin frontend only in vtadmin docker image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * vtadmin replace sed and custom entrypoint with config.js file Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * remove vitess web files in lite docker image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * move vtadmin config into a specific directory Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * restore vtadmin web file in mysql57 lite docker image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> Co-authored-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Léopold Jacquot <leopold.jacquot@gmail.com> Co-authored-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
* CherryPick: VDiff2: Support Resuming VDiffs (vitessio#10497) And fix a number of bugs discovered related to incorrect VDiff summary handling and other more minor things. Signed-off-by: Matt Lord <mattalord@gmail.com>
…test + compressors (#119) * Delete all legacy sharding related code (vitessio#10278) * Delete all legacy sharding related code Signed-off-by: Matt Lord <mattalord@gmail.com> * Move used until functions from initialsharding to cluster Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove vtctl commands Signed-off-by: Matt Lord <mattalord@gmail.com> * Kill vtworker and SetKeyspaceServedFrom cmd Signed-off-by: Matt Lord <mattalord@gmail.com> * WaitForDrain related stragglers Signed-off-by: Matt Lord <mattalord@gmail.com> * Legacy local straggler workflow Signed-off-by: Matt Lord <mattalord@gmail.com> * Get rid of SetKeyspaceShardingInfo & wait for drain stragglers Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove vtworker stragglers Signed-off-by: Matt Lord <mattalord@gmail.com> * Update throttlerservice protobuf Signed-off-by: Matt Lord <mattalord@gmail.com> * Rename test 24, add hashicorp vault test to it (now mysql_server_vault) Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove last mentiones of legacy sharding in vtctl Signed-off-by: Matt Lord <mattalord@gmail.com> * remove binlog_use_v3_resharding_mode Signed-off-by: Matt Lord <mattalord@gmail.com> * Address review comments Signed-off-by: Matt Lord <mattalord@gmail.com> * Address review comments Signed-off-by: Matt Lord <mattalord@gmail.com> * Correct vtgate help output Signed-off-by: Matt Lord <mattalord@gmail.com> * go fmt Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Remove v2 resharding fields (vitessio#10409) * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * generate vtadmin files Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * cleanup: remove sharding_column_name and sharding_column_type from vtadmin Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * Merge from main Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * Fix bad merge conflict resolution Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix missing 'sharding' import Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix bad conflict resolution in go/test/endtoend/cellalias/cell_alias_test.go Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Backup/Restore: add support for external compressors and decompressors (vitessio#10558) * change to support an external decompressor Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * add external compressor support + builtin additional compressors Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * wrap external compressor/decompressor Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * go mod tidy + comments Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * add copyright notices Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * add support for builtin engine Signed-off-by: Renan Rangel <rrangel@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Adding test case for buckup compression Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing unit test and run mod tidy Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Removing unwanted unit tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Increase timeout of backup tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing linter errors Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Change test logic to accomodate running selective tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * removing lint warning Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing test failure Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Removing un-necessary test Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing code review feeback Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Change builtinEngine to consider 'auto' decompressor Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing Upgrade/Downgrade test Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fix type & add summary under release notes Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing typos in summary Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing flag name typos Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Co-authored-by: Renan Rangel <rrangel@slack-corp.com> Co-authored-by: Renan Rangel <renan@slack-corp.com> * Add MySQL 8 Support to Backup Tests (vitessio#10691) * Add support for MySQL 8.0 in backup tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Add 8.0 workflow Signed-off-by: Matt Lord <mattalord@gmail.com> * whitespace Signed-off-by: Matt Lord <mattalord@gmail.com> * Use vtctldclient SetKeyspaceDurabilityPolicy to manage semi-sync This needed to be done after the shard was setup in order to satisfy the semantic assumptions related to semi-sync in the tests. Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove extraneous changes Signed-off-by: Matt Lord <mattalord@gmail.com> * We need lz4 for TestXtrabackupStreamWithlz4Compression Signed-off-by: Matt Lord <mattalord@gmail.com> * Try using Percona Repo for MySQL 8 to align mysqld and xtrabackup versions Signed-off-by: Matt Lord <mattalord@gmail.com> * Specify stream type everywhere Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove repeated server install Signed-off-by: Matt Lord <mattalord@gmail.com> * Moar... Signed-off-by: Matt Lord <mattalord@gmail.com> * Move vtctlbackup test to 8.0 Signed-off-by: Matt Lord <mattalord@gmail.com> * Rename vtbackup test and move to MySQL 8 Signed-off-by: Matt Lord <mattalord@gmail.com> * Split the xbstream tests so the workflow doesn't time out Otherwise it was going over the 10min limit and getting killed. Signed-off-by: Matt Lord <mattalord@gmail.com> * Use MySQL 8 compat method for setting passwords Signed-off-by: Matt Lord <mattalord@gmail.com> * Test increasing timeout at another level Signed-off-by: Matt Lord <mattalord@gmail.com> * Don't use the init passwords file with 8.0 mysqlctl doesn't start... This is likely due to the change in initialization behavior with MySQL 8.0 as it goes though two phases and you can't simply start up mysqld and pass it data, it has to initialize and restart first. Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix incorrect password update statement for vt_repl user Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Bump timeouts for 8.0 backup tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Bump it more :( Signed-off-by: Matt Lord <mattalord@gmail.com> * Increase backup/restore timeout in backup_utils Signed-off-by: Matt Lord <mattalord@gmail.com> * Apply new 8.0 template everywhere Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix bugs around how the compression flags were getting passed Signed-off-by: Matt Lord <mattalord@gmail.com> * Use 45m timeout for the workflow, 30m for the run. Signed-off-by: Matt Lord <mattalord@gmail.com> * These changes were no longer needed so limiting diff. Signed-off-by: Matt Lord <mattalord@gmail.com> * Explicitly skip new linter check Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> * Fix test file merge issues Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Go 1.18.7 to fix error Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix lint Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix vttablet.txt Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Remove sharding_column_name and sharding_column_type from vtctld2 (vitessio#10459) * Remove sharding_column_name and sharding_column_type Signed-off-by: notfelineit <notfelineit@gmail.com> * Run make web_build to compile production files Signed-off-by: notfelineit <notfelineit@gmail.com> * Remove vars from test Signed-off-by: notfelineit <notfelineit@gmail.com> * Remove sharding column type select box test from web test Signed-off-by: notfelineit <notfelineit@gmail.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Arvind Murty <arvind.murty@gmail.com> Signed-off-by: notfelineit <notfelineit@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Arvind Murty <arvind.murty@gmail.com> Co-authored-by: Rameez Sajwani <rameezwazirali@hotmail.com> Co-authored-by: Renan Rangel <rrangel@slack-corp.com> Co-authored-by: Renan Rangel <renan@slack-corp.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Frances Thai <31225471+notfelineit@users.noreply.github.com>
…test + compressors (#119) (#124) * Delete all legacy sharding related code (vitessio#10278) * Delete all legacy sharding related code * Move used until functions from initialsharding to cluster * Remove vtctl commands * Kill vtworker and SetKeyspaceServedFrom cmd * WaitForDrain related stragglers * Legacy local straggler workflow * Get rid of SetKeyspaceShardingInfo & wait for drain stragglers * Remove vtworker stragglers * Update throttlerservice protobuf * Rename test 24, add hashicorp vault test to it (now mysql_server_vault) * Remove last mentiones of legacy sharding in vtctl * remove binlog_use_v3_resharding_mode * Address review comments * Address review comments * Correct vtgate help output * go fmt * Remove v2 resharding fields (vitessio#10409) * cleanup: remove sharding_column_name and sharding_column_type * cleanup: remove sharding_column_name and sharding_column_type * cleanup: remove sharding_column_name and sharding_column_type * cleanup: remove sharding_column_name and sharding_column_type * generate vtadmin files * cleanup: remove sharding_column_name and sharding_column_type from vtadmin * Merge from main * Fix bad merge conflict resolution * Fix missing 'sharding' import * Fix bad conflict resolution in go/test/endtoend/cellalias/cell_alias_test.go * Backup/Restore: add support for external compressors and decompressors (vitessio#10558) * change to support an external decompressor * add external compressor support + builtin additional compressors * wrap external compressor/decompressor * go mod tidy + comments * add copyright notices * add support for builtin engine * Adding test case for buckup compression * Fixing unit test and run mod tidy * Removing unwanted unit tests * Increase timeout of backup tests * fixing linter errors * Change test logic to accomodate running selective tests * removing lint warning * fixing test failure * Removing un-necessary test * Fixing code review feeback * Change builtinEngine to consider 'auto' decompressor * fixing Upgrade/Downgrade test * Fix type & add summary under release notes * Fixing typos in summary * Fixing flag name typos * Add MySQL 8 Support to Backup Tests (vitessio#10691) * Add support for MySQL 8.0 in backup tests * Add 8.0 workflow * whitespace * Use vtctldclient SetKeyspaceDurabilityPolicy to manage semi-sync This needed to be done after the shard was setup in order to satisfy the semantic assumptions related to semi-sync in the tests. * Remove extraneous changes * We need lz4 for TestXtrabackupStreamWithlz4Compression * Try using Percona Repo for MySQL 8 to align mysqld and xtrabackup versions * Specify stream type everywhere * Remove repeated server install * Moar... * Move vtctlbackup test to 8.0 * Rename vtbackup test and move to MySQL 8 * Split the xbstream tests so the workflow doesn't time out Otherwise it was going over the 10min limit and getting killed. * Use MySQL 8 compat method for setting passwords * Test increasing timeout at another level * Don't use the init passwords file with 8.0 mysqlctl doesn't start... This is likely due to the change in initialization behavior with MySQL 8.0 as it goes though two phases and you can't simply start up mysqld and pass it data, it has to initialize and restart first. * Fix incorrect password update statement for vt_repl user * Bump timeouts for 8.0 backup tests * Bump it more :( * Increase backup/restore timeout in backup_utils * Apply new 8.0 template everywhere * Fix bugs around how the compression flags were getting passed * Use 45m timeout for the workflow, 30m for the run. * These changes were no longer needed so limiting diff. * Explicitly skip new linter check * Fix test file merge issues * Go 1.18.7 to fix error * Fix lint * Fix vttablet.txt * Remove sharding_column_name and sharding_column_type from vtctld2 (vitessio#10459) * Remove sharding_column_name and sharding_column_type * Run make web_build to compile production files * Remove vars from test * Remove sharding column type select box test from web test --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Arvind Murty <arvind.murty@gmail.com> Signed-off-by: notfelineit <notfelineit@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Arvind Murty <arvind.murty@gmail.com> Co-authored-by: Rameez Sajwani <rameezwazirali@hotmail.com> Co-authored-by: Renan Rangel <rrangel@slack-corp.com> Co-authored-by: Renan Rangel <renan@slack-corp.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Frances Thai <31225471+notfelineit@users.noreply.github.com>
* Switch to `pflag` for all parsing This transparently swaps the cli parsing library used by `internal/flag` from the standard library `flag` package to `spf13/pflag`. It also introduces hook points for packages throughout the vitess codebase to register their flags for either all commands using `servenv` or a particular subset of commands. This allows these packages to continue to define their flag variables in a package-private way, but without polluting the global flagset. * Workaround exit code difference between stdlib `flag` and `pflag` tl;dr stdlib `flag` has [this][1] and `pflag` does not [1]: golang/go@dcf0929 * adjust test data for difference in spacing between pflag/stdflag * update lingering legacy flag tests * Update vtgate/tabletgateway.go to use new interface to isolate flags, update test data * update flags in java test code Signed-off-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
* apply patch 11909 Signed-off-by: Priya Bibra <pbibra@slack-corp.com> * fix typo Signed-off-by: Priya Bibra <pbibra@slack-corp.com> --------- Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
* Upgrade go slack vitess r14.0.5 (#91) * Cleanup usage of go.rice in favor of go:embed (vitessio#10956) * Cleanup usage of go.rice in favor of go:embed The usage of go.rice predates the availability of go:embed, but we should switch to using go:embed instead to ship specific assets like config files that we need. go.rice is also incompatible with Go 1.19 and while it might see a fix in the future, it seems better to go with the recommended Go approach that is available these days. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Move vtctld to also use `go embed` instead of go.rice Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Remove last rice-box related comments Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Remove config moving This right now breaks building the actual tests since the tests might also end up loading the regular code which has a `go embed` and refers to the package with the config embeds. This doesn't mean that the config isn't properly included in the binaries. Also with using `go embed` we have a build time dependency on the files and we always know the latest is included, so we don't have the issue of potentially outdated files either. All in all, it seems simplest to remove this logic and trust that Go itself works as advertised. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * fix vtrootbin Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * update the build to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * update the workflows to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * update the docker image to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * update the bootstrap version to get docker to go 1.20.5 Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * use 1.18.7 for static checks Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * lower the build version requirement to allow static checks to pass Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * experiment with using old and new Go for a single workflow Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * use old and new Go for a upgrade/downgrade workflows Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * set -buildvcs=false Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * address build errors Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * Revert "fix parameter name (#93)" (#100) This reverts commit 76159fd. * apply patch 12178 to v14 (#102) Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Signed-off-by: 'Priya Bibra' <pbibra@slack-corp.com> * more workflows to use self-hosted runner * even more workflows to use self-hosted runner * partially switch upgrade-downgrade to self-hosted runner * Ejortegau/larger runners (#115) * Empty commit to trigger CI Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * `slack-vitess-r14.0.5-dsdefense`: use larger runner Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Use runner group instead Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Rename group Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Move more jobs to runner group Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * use vitess-ubuntu20 runner group Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Rever change of runner type for e2e ERS PRS new features heavy test Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> --------- Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com> * Revert change of runner type for shardedrecovery_stress_verticalsplit_heavy. (#116) We do this because the test is taking a lot longer & failing in some cases with the larger runner. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * `slack-vitess-r14.0.5`: use dedicated larger runner (#113) * `slack-vitess-r14.0.5`: use dedicated larger runner Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix fileNameFromPosition Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * empty commit Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * empty commit Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * `slack-vitess-r14.0.5`: allow conn overrides in consul topo (#111) * `slack-vitess-r14.0.5`: allow conn overrides in consul topo Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix e2e test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Signed-off-by: 'Priya Bibra' <pbibra@slack-corp.com> Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Roderick Yao <roderick.yao@slack-corp.com> Co-authored-by: pbibra <pbibra@slack-corp.com> Co-authored-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com> * Upgrade go slack vitess r14.0.5 (#91) * Cleanup usage of go.rice in favor of go:embed (vitessio#10956) * Cleanup usage of go.rice in favor of go:embed The usage of go.rice predates the availability of go:embed, but we should switch to using go:embed instead to ship specific assets like config files that we need. go.rice is also incompatible with Go 1.19 and while it might see a fix in the future, it seems better to go with the recommended Go approach that is available these days. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Move vtctld to also use `go embed` instead of go.rice Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Remove last rice-box related comments Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Remove config moving This right now breaks building the actual tests since the tests might also end up loading the regular code which has a `go embed` and refers to the package with the config embeds. This doesn't mean that the config isn't properly included in the binaries. Also with using `go embed` we have a build time dependency on the files and we always know the latest is included, so we don't have the issue of potentially outdated files either. All in all, it seems simplest to remove this logic and trust that Go itself works as advertised. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * fix vtrootbin Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * update the build to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * update the workflows to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * update the docker image to 1.19.10 Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * update the bootstrap version to get docker to go 1.20.5 Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * use 1.18.7 for static checks Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * lower the build version requirement to allow static checks to pass Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * experiment with using old and new Go for a single workflow Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * use old and new Go for a upgrade/downgrade workflows Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * set -buildvcs=false Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * address build errors Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> * Revert "fix parameter name (#93)" (#100) This reverts commit 76159fd. * apply patch 12178 to v14 (#102) Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Signed-off-by: 'Priya Bibra' <pbibra@slack-corp.com> * more workflows to use self-hosted runner * even more workflows to use self-hosted runner * partially switch upgrade-downgrade to self-hosted runner * Ejortegau/larger runners (#115) * Empty commit to trigger CI Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * `slack-vitess-r14.0.5-dsdefense`: use larger runner Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Use runner group instead Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Rename group Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Move more jobs to runner group Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * use vitess-ubuntu20 runner group Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Rever change of runner type for e2e ERS PRS new features heavy test Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> --------- Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com> * Revert change of runner type for shardedrecovery_stress_verticalsplit_heavy. (#116) We do this because the test is taking a lot longer & failing in some cases with the larger runner. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * `slack-vitess-r14.0.5`: use dedicated larger runner (#113) * `slack-vitess-r14.0.5`: use dedicated larger runner Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix fileNameFromPosition Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * empty commit Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * empty commit Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * `slack-vitess-r14.0.5`: allow conn overrides in consul topo (#111) * `slack-vitess-r14.0.5`: allow conn overrides in consul topo Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix e2e test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Signed-off-by: 'Priya Bibra' <pbibra@slack-corp.com> Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Roderick Yao <roderick.yao@slack-corp.com> Co-authored-by: pbibra <pbibra@slack-corp.com> Co-authored-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com> * Cleaning up bad merge * Fixing the build cmds --------- Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: 'Stanislav Maksimov' <smaksimov@slack-corp.com> Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Signed-off-by: 'Priya Bibra' <pbibra@slack-corp.com> Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Roderick Yao <roderick.yao@slack-corp.com> Co-authored-by: pbibra <pbibra@slack-corp.com> Co-authored-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
* apply patch 12623 Signed-off-by: Priya Bibra <pbibra@slack-corp.com> * fix unit test Signed-off-by: Priya Bibra <pbibra@slack-corp.com> * revert regex Signed-off-by: Priya Bibra <pbibra@slack-corp.com> * update regex Signed-off-by: Priya Bibra <pbibra@slack-corp.com> --------- Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
* apply patch 13547 Signed-off-by: Priya Bibra <pbibra@slack-corp.com> * adding missing param Signed-off-by: Priya Bibra <pbibra@slack-corp.com> * remove throttlerapp ref Signed-off-by: Priya Bibra <pbibra@slack-corp.com> --------- Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
* refactor: refactor vtorc tests to run as a single test with sub-tests (vitessio#11108) Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> * `vtctld`/`vtorc`: improve reparenting stats (vitessio#13723) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com> * revert changes to go/test/endtoend Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * remove unrelated+incompatible test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix memorytopo.NewServer(...) for v14 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * remove non-existant "PrimaryStatusResults" field Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Remove FOSSA Test from CI until we can do it in a secure way (vitessio#14119) Signed-off-by: Rohit Nayak <rohit@planetscale.com> --------- Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com> Co-authored-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Rohit Nayak <57520317+rohit-nayak-ps@users.noreply.github.com>
This reverts commit ebcb671.
* make column resolution closer to mysql Signed-off-by: Andres Taylor <andres@planetscale.com> * Fix bad merge conflict fix Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Possible horizon_planning.go fix Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix aggr_cases.json plan Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix group by order Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Remove 'TablesUsed', not in v14 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Andres Taylor <andres@planetscale.com>
) (#167) * `slack-vitess-r14.0.5`: backport vitessio#14428 from v16 (#165) * make column resolution closer to mysql Signed-off-by: Andres Taylor <andres@planetscale.com> * Fix bad merge conflict fix Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Possible horizon_planning.go fix Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix aggr_cases.json plan Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix group by order Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Remove 'TablesUsed', not in v14 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Andres Taylor <andres@planetscale.com> * Update e2e vttablet.txt Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Update e2e vtgate.txt Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Checklist
Deployment Notes