-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce flakiness in TestShardReplicationPositions #14708
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vitessio#14707. In CI, sometimes 10ms is exhausted simply in context switching, so we end up timing out the request before calling `GetTabletMapByShard`, rather than in the tabletmanager RPCs we are trying to have timeout. Bumping the timeout by 10x to try to reduce flakiness. Signed-off-by: Andrew Mason <andrew@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Dec 6, 2023
rohit-nayak-ps
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Dec 7, 2023
rohit-nayak-ps
approved these changes
Dec 7, 2023
mattlord
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it's probably worth going even higher since I've seen 1+ second pauses (CPU stalls) when SSH'd into the runners in the past. But 10x should definitely help.
let me bump it a bit further then! |
Signed-off-by: Andrew Mason <andrew@planetscale.com>
ajm188
force-pushed
the
andrew/bump-test-timeouts
branch
from
December 7, 2023 17:53
001e97d
to
fdf5a3f
Compare
ejortegau
pushed a commit
to slackhq/vitess
that referenced
this pull request
Dec 13, 2023
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In CI, sometimes 10ms is exhausted simply in context switching, so we end up timing out the request before calling
GetTabletMapByShard
, rather than in the tabletmanager RPCs we are trying to have timeout.Bumping the timeout by 10x to try to reduce flakiness.
Related Issue(s)
Fixes #14707.
Checklist
Deployment Notes