Explain Statement plan improvement

[harshit-gangal]

Description

In order to support EXPLAIN on more queries, we need to do a little bit of table name massaging before sending down the EXPLAIN query to MySQL. Specifically, we need to handle routed tables correctly, since they don't have the same name in Vitess as they do in the underlying MySQL instance.

Related Issue(s)

Fixes #14961

Checklist

• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required update explain format=vitess doc to use vexplain plan website#1669

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[harshit-gangal]

doc update needed: https://vitess.io/docs/18.0/concepts/execution-plans/#observing-execution-plans

[codecov]

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (17e7f84) 47.38% compared to head (2f83cb6) 47.39%.
Report is 6 commits behind head on main.

Files	Patch %	Lines
go/vt/vtgate/semantics/semantic_state.go	0.00%	20 Missing ⚠️
go/vt/sqlparser/ast_funcs.go	0.00%	14 Missing ⚠️
go/vt/vtgate/planbuilder/vexplain.go	65.71%	9 Missing and 3 partials ⚠️
go/vt/vtgate/planbuilder/builder.go	60.00%	2 Missing ⚠️
go/vt/vtgate/planbuilder/operators/SQL_builder.go	0.00%	2 Missing ⚠️
go/vt/vtgate/planbuilder/operators/join.go	0.00%	2 Missing ⚠️
go/vt/vtgate/planbuilder/operators/ast_to_op.go	0.00%	1 Missing ⚠️
...t/vtgate/planbuilder/operators/subquery_builder.go	0.00%	1 Missing ⚠️
go/vt/vtgate/planbuilder/operators/table.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14928      +/-   ##
==========================================
+ Coverage   47.38%   47.39%   +0.01%     
==========================================
  Files        1145     1145              
  Lines      239155   239185      +30     
==========================================
+ Hits       113322   113372      +50     
+ Misses     117249   117237      -12     
+ Partials     8584     8576       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[harshit-gangal]

Docs PR: vitessio/website#1669

[frouioui]

It is not clear to me if vtexplain all or just vtexplain queries, will actually run queries

[harshit-gangal]

both of them will. only vexplain plan does not run it.

[frouioui]

Should we add end-to-end tests for this?

Otherwise, it all looks good to me