Move MySQL56 to MySQL for replication related values

[mattlord]

Description

Related Issue(s)

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

Attention: Patch coverage is 77.65957% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 47.26%. Comparing base (b15e9f6) to head (88ae836).
Report is 479 commits behind head on main.

Files	Patch %	Lines
go/mysql/flavor_mysql.go	0.00%	5 Missing ⚠️
go/vt/mysqlctl/builtinbackupengine.go	37.50%	4 Missing and 1 partial ⚠️
go/mysql/binlog_event_mysql.go	83.33%	2 Missing ⚠️
go/mysql/replication/mysql_gtid_set.go	92.59%	1 Missing and 1 partial ⚠️
go/mysql/replication/replication_position.go	0.00%	2 Missing ⚠️
go/mysql/binlog_event_make.go	92.30%	1 Missing ⚠️
go/mysql/replication/replication_status.go	87.50%	1 Missing ⚠️
go/vt/vtctl/reparentutil/replication.go	66.66%	1 Missing ⚠️
...t/vttablet/tabletserver/vstreamer/snapshot_conn.go	0.00%	1 Missing ⚠️
go/vt/vttablet/tabletserver/vstreamer/vstreamer.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14977      +/-   ##
==========================================
- Coverage   47.27%   47.26%   -0.01%     
==========================================
  Files        1138     1138              
  Lines      238842   238842              
==========================================
- Hits       112907   112887      -20     
- Misses     117342   117363      +21     
+ Partials     8593     8592       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[deepthi]

Won't this break existing vstream clients? And/or integrations like Debezium?

[mattlord]

Won't this break existing vstream clients? And/or integrations like Debezium?

It could. I'd have to think of a way to avoid that -- supporting both for some time.

[github-actions]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[github-actions]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[deepthi]

My suggestion is as follows:

• Don't change GTID format. That will break contracts with clients
• Feel free to change function names etc.

Anyhow this isn't super important. Just confusing for anyone new to the code base.

[github-actions]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[github-actions]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[github-actions]

This PR was closed because it has been stale for 7 days with no activity.