-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added unit tests for vt/grpcclient package #15072
Added unit tests for vt/grpcclient package #15072
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
60581f8
to
3227054
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15072 +/- ##
==========================================
+ Coverage 65.49% 65.67% +0.18%
==========================================
Files 1562 1562
Lines 193940 193940
==========================================
+ Hits 127016 127378 +362
+ Misses 66924 66562 -362 ☔ View full report in Codecov by Sentry. |
@GuptaManan100 could you please take a look at these tests? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest looks good to me!
3227054
to
404db59
Compare
Signed-off-by: VaibhavMalik4187 <vaibhavmalik2018@gmail.com>
404db59
to
38eac48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. There is a conflict though, you might need to merge main
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Description
Bumps the coverage of the
go/vt/grpcclient
package to 70%Related Issue(s)
Partially Addresses: #14931
Checklist