-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-18.0] make sure to handle unsupported collations well (#15134) #15142
Conversation
Hello @systay, there are conflicts in this backport. Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually. Make sure you replace
|
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Andres Taylor <andres@planetscale.com>
614d415
to
ebcc0fe
Compare
@@ -501,7 +501,12 @@ func loadSchema(t testing.TB, filename string, setCollation bool) *vindexes.VSch | |||
for _, table := range ks.Tables { | |||
for i, col := range table.Columns { | |||
if sqltypes.IsText(col.Type) { | |||
table.Columns[i].CollationName = "latin1_swedish_ci" | |||
switch col.Name.String() { | |||
case "textcol2": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In v18, the proto files don't contain the collation name, so I can't set it on schema.json
as I did on main
. This is the hack I did to get collations in.
Signed-off-by: Andres Taylor <andres@planetscale.com>
Description
This is a backport of #15134