mysql: move colldump to its own standalone repository

[vmg]

Description

We have received a friendly email from the CNCF with an automated license scanner pass that raised concerns about the GPLv2 license in colldump.cc. Just to clarify, the code in colldump.cc is licensed under the GPLv2 because it links against MySQL: it's used as a codegen step to dump collation data. This collation data is not GPL licensed (it cannot possibly be, because it can also be dumped via SQL queries to a running MySQL database). Hence, this is not a licensing conflict. The colldump.cc code is not part of Vitess, it's not linked against Vitess, and it's only used for code generation.

Buuuut instead of fighting the heuristics of the license scanner, I'm just going to move the code to its own repository, which will appease the linter.

cc @systay @harshit-gangal

Related Issue(s)

• https://lists.cncf.io/g/cncf-vitess-maintainers/pendingmsg?id=9299734
• https://lfscanning.org/reports/cncf/vitess-2024-01-03-f18b18c3-e0f7-4f1f-a94a-fbff20197af6.html

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

Attention: 134 lines in your changes are missing coverage. Please review.

Comparison is base (eddb39e) 47.29% compared to head (10dc775) 70.65%.
Report is 114 commits behind head on main.

Files	Patch %	Lines
go/vt/mysqlctl/builtinbackupengine.go	12.90%	54 Missing ⚠️
go/vt/mysqlctl/backupengine.go	0.00%	20 Missing ⚠️
go/vt/mysqlctl/xtrabackupengine.go	0.00%	15 Missing ⚠️
go/vt/schemadiff/column.go	70.83%	7 Missing ⚠️
go/mysql/conn.go	53.84%	6 Missing ⚠️
go/vt/mysqlctl/backup.go	37.50%	5 Missing ⚠️
go/mysql/capabilities/capability.go	91.48%	4 Missing ⚠️
go/mysql/query.go	77.77%	4 Missing ⚠️
go/vt/mysqlctl/schema.go	72.72%	3 Missing ⚠️
go/vt/schemadiff/schema.go	92.10%	3 Missing ⚠️
... and 9 more

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #15166       +/-   ##
===========================================
+ Coverage   47.29%   70.65%   +23.35%     
===========================================
  Files        1137     1377      +240     
  Lines      238684   182801    -55883     
===========================================
+ Hits       112895   129152    +16257     
+ Misses     117168    53649    -63519     
+ Partials     8621        0     -8621     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.