-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tablet throttler: adding more stats #15224
Merged
shlomi-noach
merged 2 commits into
vitessio:main
from
planetscale:throttler-more-metrics
Feb 15, 2024
Merged
Tablet throttler: adding more stats #15224
shlomi-noach
merged 2 commits into
vitessio:main
from
planetscale:throttler-more-metrics
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
requested review from
harshit-gangal,
systay,
rohit-nayak-ps,
deepthi and
GuptaManan100
as code owners
February 14, 2024 07:08
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Feb 14, 2024
shlomi-noach
added
Type: Feature
Component: Throttler
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Feb 14, 2024
rohit-nayak-ps
approved these changes
Feb 14, 2024
mattlord
approved these changes
Feb 14, 2024
We should document the throttler metrics either here: https://vitess.io/docs/19.0/reference/features/tablet-throttler/#information or in a new For example: https://vitess.io/docs/19.0/reference/vreplication/metrics/ and vitessio/website#1687 |
Docs PR: vitessio/website#1690 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #15223 by adding these counter metrics:
ThrottlerHeartbeatRequests
: incremented each time the throttler requests heartbeat lease (especially useful when--heartbeat_on_demand_duration
is set).ThrottlerRecentlyChecked
: for when a tablet's throttler is recently checked. This applies to any tablet type. For example, a vreplicationrowstream
could run on a particular replica. That replica would report itself as being "recently checked".ThrottlerProbeRecentlyChecked
: for when aPRIMARY
tablet throttler probes the shard tablets, and one of the probed tablets reports it has been "recently checked".ThrottlerCheckRequest
: when a tablet receives a gRPCCheckThrottler
call.These metrics will help to pinpoint throttler behavior, and better understand the flow of requests.
Related Issue(s)
Checklist
Deployment Notes