-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated vtctl commands #15228
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15228 +/- ##
==========================================
- Coverage 67.41% 65.70% -1.72%
==========================================
Files 1560 1562 +2
Lines 192752 193902 +1150
==========================================
- Hits 129952 127397 -2555
- Misses 62800 66505 +3705 ☔ View full report in Codecov by Sentry. |
e2e5952
to
35b0559
Compare
These commands were deprecated even before the vtctldclient migration, so they are doubly-safe to remove. Signed-off-by: Andrew Mason <andrew@planetscale.com>
cce3928
to
7820f3c
Compare
Signed-off-by: Andrew Mason <andrew@planetscale.com>
1ccd99b
to
b52a0ea
Compare
Something to address in this PR - #14871 (comment) |
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
closing this as i won't have time to work on it for a while, please free to pick up this branch though! |
Description
e9aab81093 - These commands were deprecated even before the vtctldclient migration, so they are doubly-safe to remove.
Related Issue(s)
Checklist
Deployment Notes