Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemadiff: supporting textual diff #15388

Merged
merged 23 commits into from
Mar 18, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
comments
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach committed Feb 26, 2024

Verified

This commit was signed with the committer’s verified signature.
shlomi-noach Shlomi Noach
commit 68404999de7421b5052f95c42fe39edd3f2c893f
6 changes: 3 additions & 3 deletions go/vt/schemadiff/table_test.go
Original file line number Diff line number Diff line change
@@ -2009,13 +2009,13 @@ func TestCreateTableDiff(t *testing.T) {
assert.NotEqual(t, eToStatementString, annotatedToString)
}
}
if len(ts.textdiffs) > 0 {
if len(ts.textdiffs) > 0 { // Still incomplete.
// For this test, we should validate the given diffs
uniqueDiffs := make(map[string]bool)
for _, textdiff := range ts.textdiffs {
uniqueDiffs[textdiff] = true
}
assert.Equal(t, len(uniqueDiffs), len(ts.textdiffs))
// For this test, we should validate the given diffs
require.Equal(t, len(uniqueDiffs), len(ts.textdiffs)) // integrity of test
for _, textdiff := range ts.textdiffs {
assert.Containsf(t, annotatedUnifiedString, textdiff, annotatedUnifiedString)
}