Skip to content

VReplication: use new topo named locks and TTL override for workflow coordination #16260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 10, 2024

Address review comment

8de719a
Select commit
Loading
Failed to load commit list.
Merged

VReplication: use new topo named locks and TTL override for workflow coordination #16260

Address review comment
8de719a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 8, 2024 in 0s

68.69% (-0.02%) compared to 0db3577, passed because coverage increased by -0.01% when compared to adjusted base (68.70%)

View this Pull Request on Codecov

68.69% (-0.02%) compared to 0db3577, passed because coverage increased by -0.01% when compared to adjusted base (68.70%)

Details

Codecov Report

Attention: Patch coverage is 64.52991% with 83 lines in your changes missing coverage. Please review.

Project coverage is 68.69%. Comparing base (0db3577) to head (8de719a).

Files Patch % Lines
go/vt/vtctl/workflow/server.go 52.22% 43 Missing ⚠️
go/vt/topo/faketopo/faketopo.go 0.00% 8 Missing ⚠️
go/vt/topo/locks.go 77.14% 8 Missing ⚠️
go/vt/topo/consultopo/lock.go 53.84% 6 Missing ⚠️
go/vt/topo/etcd2topo/lock.go 40.00% 6 Missing ⚠️
go/vt/vttablet/tabletmanager/vdiff/table_differ.go 0.00% 5 Missing ⚠️
go/vt/topo/zk2topo/lock.go 0.00% 4 Missing ⚠️
...lient/command/vreplication/common/switchtraffic.go 0.00% 2 Missing ⚠️
go/vt/topo/memorytopo/lock.go 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16260      +/-   ##
==========================================
- Coverage   68.71%   68.69%   -0.02%     
==========================================
  Files        1547     1548       +1     
  Lines      198287   198444     +157     
==========================================
+ Hits       136243   136330      +87     
- Misses      62044    62114      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.