-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-20.0] Fix Incorrect Optimization with LIMIT and GROUP BY (#16263) #16268
Conversation
Signed-off-by: Andres Taylor <andres@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-20.0 #16268 +/- ##
=============================================
Coverage 68.60% 68.60%
=============================================
Files 1541 1541
Lines 197812 197814 +2
=============================================
+ Hits 135702 135718 +16
+ Misses 62110 62096 -14 ☔ View full report in Codecov by Sentry. |
go/test/endtoend/vtgate/queries/aggregation/aggregation_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
go/test/endtoend/vtgate/queries/aggregation/aggregation_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should merge #16267 first for the upgrade/downgrade test.
Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
d914e7f
to
d05f982
Compare
I forced push the same commit again on this PR, for some reason the CI workflows were blocked in |
go/test/endtoend/vtgate/queries/aggregation/aggregation_test.go
Outdated
Show resolved
Hide resolved
Dismissing as the end-to-end test seems to be wrong.
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Description
This is a backport of #16263