Online DDL: remove legacy (and ancient) 'REVERT <uuid>' syntax

[shlomi-noach]

Description

This is a long overdue cleanup PR, removing support for a long since unused revert syntax.

To revert a migration, we use this syntax: revert vitess_migration '<uuid'>.

When revert was first introduced, we used this syntax: revert <uuid>. This syntax is not being used in over 3 years now since the new syntax was introduced.

This PR cleans up support of the old syntax.

Related Issue(s)

• Support for REVERT VITESS_MIGRATION statement #7656
• OnlineDDL: Revert for VReplication based migrations #7478
• Online DDL: tracking issue #6926

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[shlomi-noach]

Looking into the failing tests.

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.71%. Comparing base (bb76046) to head (5191c55).
Report is 2 commits behind head on main.

Files	Patch %	Lines
go/vt/vtgate/engine/revert_migration.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16301      +/-   ##
==========================================
- Coverage   68.71%   68.71%   -0.01%     
==========================================
  Files        1544     1544              
  Lines      198011   197991      -20     
==========================================
- Hits       136064   136042      -22     
- Misses      61947    61949       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shlomi-noach]

I definitely broke something in VTGate parsing.

$ mysql -e "revert vitess_migration '8997525e_37ad_11ef_a6fd_0a43f95f28a3'"
ERROR 1105 (HY000) at line 1: syntax error at position 16 near '8997525e'

should have succeeded. ApplySchema does work:

$ vtctldclient ApplySchema --ddl-strategy "online" --sql "revert vitess_migration '8997525e_37ad_11ef_a6fd_0a43f95f28a3'" commerce
a5814e1c_37ad_11ef_a6fd_0a43f95f28a3

[shlomi-noach]

Found the issue. Tests should pass now.