Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction watcher and notifier #16363

Merged
merged 10 commits into from
Jul 17, 2024
Merged

Transaction watcher and notifier #16363

merged 10 commits into from
Jul 17, 2024

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Jul 10, 2024 •
edited
Loading

Description

This PR watches unresolved transactions and uses the vttablet health stream to notify.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jul 10, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 10, 2024
@harshit-gangal harshit-gangal added Skip CI Skip CI actions from running and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 10, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jul 10, 2024
@harshit-gangal
proto: added unresolved distributed transaction signal to health stream
be7f3b7 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
feat: notify unresolved transaction through health stream using trans…
81de2fb 
…action watcher

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
remove coodinator address
2aac6ae 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
fix: dt_state create statement
65b5020 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal added Type: Feature Component: Query Serving and removed Skip CI Skip CI actions from running labels Jul 11, 2024
@harshit-gangal
count on dt_state and dt_redo for unresolved transactions and unresol…
cd7b707 
…ved prepared transactions

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
ordering unresolved transaction by state, added test. commit > rollba…
9ad5ddf 
…ck > prepare

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
test: update transaction notifier test
e9e3626 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@codecov Codecov
Copy link

codecov bot commented Jul 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.28571% with 15 lines in your changes missing coverage. Please review.

Project coverage is 68.65%. Comparing base (ba5297d) to head (9c64c1c).
Report is 4 commits behind head on main.

Files Patch % Lines
go/vt/vttablet/tabletserver/health_streamer.go 0.00% 9 Missing ⚠️
go/vt/vttablet/tabletserver/tx_engine.go 69.23% 4 Missing ⚠️
go/vt/vttablet/tabletserver/twopc.go 89.47% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16363      +/-   ##
==========================================
- Coverage   68.67%   68.65%   -0.02%     
==========================================
  Files        1548     1548              
  Lines      199081   199044      -37     
==========================================
- Hits       136722   136659      -63     
- Misses      62359    62385      +26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harshit-gangal
test: added transaction watcher tests
b24906b 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal changed the title [Draft] unresolved transaction notifier unresolved transaction notifier Jul 12, 2024
@harshit-gangal harshit-gangal changed the title unresolved transaction notifier Transaction watcher and notifier Jul 12, 2024
@harshit-gangal harshit-gangal marked this pull request as ready for review July 12, 2024 15:11
@harshit-gangal harshit-gangal requested review from GuptaManan100 and removed request for shlomi-noach, timvaillancourt and rohit-nayak-ps July 12, 2024 15:11
@systay

This comment was marked as resolved.

Sign in to view
systay and others added 2 commits July 15, 2024 10:34
@systay
extract checking into test helper
b206eb7 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@harshit-gangal
Merge pull request #94 from systay/tx-resolver
9c64c1c 
test helper
@harshit-gangal
Copy link
Member Author

harshit-gangal commented Jul 15, 2024 •
edited
Loading

Since we are removing a flag, we need to update the website, right?

This will be done by doc-gen workflow.
For the Distributed Transaction section, we will do it as a separate task.

GuptaManan100
GuptaManan100 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM!

proto/query.proto
Comment on lines 990 to +992
PREPARE = 1;
COMMIT = 2;
ROLLBACK = 3;
ROLLBACK = 2;
COMMIT = 3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing this? Is this required?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to keep the order of state such that if we order on the transaction state, the commit state comes on top.

@harshit-gangal harshit-gangal merged commit c9c0aa5 into vitessio:main Jul 17, 2024
129 checks passed
@harshit-gangal harshit-gangal deleted the tx-resolver branch July 17, 2024 06:44
frouioui pushed a commit to frouioui/vitess that referenced this pull request Jul 19, 2024
@harshit-gangal @systay @frouioui
Transaction watcher and notifier (vitessio#16363)
365b2ce 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@systay systay systay approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Feature
Projects
None yet
Milestone
v21.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@harshit-gangal @systay @GuptaManan100