Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online DDL: do not update last_throttled_timestamp with zero value #16395

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

shlomi-noach
Copy link
Contributor

Description

_vt.schema_migrations.last_throttled_timestamp indicates the last time a vreplication migration was throttled, value copied from _vt.vreplication.time_throttled. However, it is possible for the value to be zero if timeThrottled is uninitialized. In this PR we avoid updating last_throttled_timestamp to the zero value.

Related Issue(s)

Fixes #16394

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach added Type: Bug Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) labels Jul 16, 2024
@shlomi-noach shlomi-noach requested a review from a team July 16, 2024 05:42
Copy link
Contributor

vitess-bot bot commented Jul 16, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 16, 2024
@shlomi-noach shlomi-noach removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 16, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jul 16, 2024
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a good idea to initialize one of the OnlineDDL tests with the strict modes that Vitess might run with.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.67%. Comparing base (3cb61cd) to head (b8a9654).
Report is 3 commits behind head on main.

Files Patch % Lines
go/vt/vttablet/onlineddl/executor.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16395      +/-   ##
==========================================
- Coverage   68.68%   68.67%   -0.02%     
==========================================
  Files        1548     1548              
  Lines      199084   199085       +1     
==========================================
- Hits       136736   136712      -24     
- Misses      62348    62373      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

It might be a good idea to initialize one of the OnlineDDL tests

Good idea, done.

@shlomi-noach
Copy link
Contributor Author

(they ought to have such sql_mode by default, since this is 8.0, but now explicitly setting it like so)

@shlomi-noach shlomi-noach merged commit 37b10ad into vitessio:main Jul 16, 2024
127 checks passed
@shlomi-noach shlomi-noach deleted the no-zero-time-throttled branch July 16, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Online DDL: zero date possible in _vt.schema_migrations.last_throttled_timestamp
3 participants