-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove JSON annotations #16437
Remove JSON annotations #16437
Conversation
Signed-off-by: Andres Taylor <andres@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the main reason why we want to remove these?
Approving to unblock.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16437 +/- ##
=======================================
Coverage 68.67% 68.68%
=======================================
Files 1548 1548
Lines 199124 199124
=======================================
+ Hits 136745 136760 +15
+ Misses 62379 62364 -15 ☔ View full report in Codecov by Sentry. |
They are unnecessary. We don't need them. So it's better to remove. |
Description
Very small PR that just removes unnecessary JSON annotations on a few types.
Related Issue(s)
Checklist