Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQL 8.4 unit tests #16440

Merged
merged 8 commits into from
Jul 24, 2024

Remove MAKETIME case

e005120
Select commit
Loading
Failed to load commit list.
Merged

Add MySQL 8.4 unit tests #16440

Remove MAKETIME case
e005120
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 23, 2024 in 0s

68.65% (-0.02%) compared to 3186413

View this Pull Request on Codecov

68.65% (-0.02%) compared to 3186413

Details

Codecov Report

Attention: Patch coverage is 62.77372% with 51 lines in your changes missing coverage. Please review.

Project coverage is 68.65%. Comparing base (3186413) to head (e005120).
Report is 5 commits behind head on main.

Files Patch % Lines
...vttablet/tabletmanager/vreplication/vreplicator.go 47.36% 20 Missing ⚠️
go/mysql/flavor_filepos.go 50.00% 8 Missing ⚠️
go/vt/vtgate/evalengine/compiler_asm.go 80.00% 5 Missing ⚠️
go/vt/vtgate/evalengine/eval_numeric.go 0.00% 4 Missing ⚠️
go/vt/vtgate/evalengine/fn_string.go 87.50% 3 Missing ⚠️
go/mysql/capabilities/capability.go 50.00% 2 Missing ⚠️
go/mysql/flavor.go 50.00% 2 Missing ⚠️
go/mysql/flavor_mysqlgr.go 0.00% 2 Missing ⚠️
go/vt/binlog/binlogplayer/dbclient.go 0.00% 2 Missing ⚠️
go/vt/binlog/binlogplayer/fake_dbclient.go 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16440      +/-   ##
==========================================
- Coverage   68.66%   68.65%   -0.02%     
==========================================
  Files        1548     1549       +1     
  Lines      199124   199323     +199     
==========================================
+ Hits       136731   136838     +107     
- Misses      62393    62485      +92

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov