Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cross cell promotion in PRS #16461

Merged
merged 5 commits into from
Jul 25, 2024

feat: use options instead of many arguments

8e01681
Select commit
Loading
Failed to load commit list.
Merged

Allow cross cell promotion in PRS #16461

feat: use options instead of many arguments
8e01681
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 25, 2024 in 0s

68.64% (-0.01%) compared to f481a77, passed because coverage increased by -0.01% when compared to adjusted base (68.64%)

View this Pull Request on Codecov

68.64% (-0.01%) compared to f481a77, passed because coverage increased by -0.01% when compared to adjusted base (68.64%)

Details

Codecov Report

Attention: Patch coverage is 68.18182% with 7 lines in your changes missing coverage. Please review.

Project coverage is 68.64%. Comparing base (f481a77) to head (8e01681).

Files Patch % Lines
go/vt/vtctl/reparent.go 0.00% 6 Missing ⚠️
go/cmd/vtctldclient/command/reparents.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16461      +/-   ##
==========================================
- Coverage   68.65%   68.64%   -0.01%     
==========================================
  Files        1551     1551              
  Lines      199468   199473       +5     
==========================================
- Hits       136935   136920      -15     
- Misses      62533    62553      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.