Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test running endtoend against MySQL 8.4 #16493

Closed
wants to merge 10,000 commits into from
Closed

Test running endtoend against MySQL 8.4 #16493

wants to merge 10,000 commits into from
+1,891,371 −403,061

Conversation

dbussink
Copy link
Contributor

Test running all these tests against MySQL 8.4 to see what fails and what we should run specifically also against MySQL 8.4

Related Issue(s)

Part of #16466

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

runewake2 and others added 30 commits July 2, 2024 16:56
@runewake2 @frouioui
Add vtctldclient container image (vitessio#16318)
397b46d 
Signed-off-by: Sam Wronski <swronski@squareup.com>
Signed-off-by: Sam Wronski <sam@worldofzero.com>
Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
@shlomi-noach
A couple changes in Online DDL CI (vitessio#16272)
99e8c01 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Heartbeat writer can always generate on-demand leased heartbeats, eve…
ebd8fbb 
…n if not at all configured (vitessio#16014)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@frouioui
Add new mysql connection drain (vitessio#16298)
ff5783b 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@mattlord
CI: Fix for xtrabackup install failures (vitessio#16329)
c70c905 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@vitess-bot @frouioui
[main] Upgrade the Golang version to go1.22.5 (vitessio#16319)
c332773 
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: frouioui <frouioui@users.noreply.github.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
@shlomi-noach
schemadiff small internal refactor: formalizing column charset/coll…
1546a5e 
…ation (vitessio#16239)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@systay
make sure to add weight_string for the right expression (vitessio#16325)
5f2cfa6 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
Prevent Early Ordering Pushdown to Enable Aggregation Pushdown to MyS…
4759297 
…QL (vitessio#16278)

Signed-off-by: Andres Taylor <andres@planetscale.com>
@harshit-gangal
Fail on prepare of reserved connection (vitessio#16316)
e07b6ce 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@systay
Improve typing during query planning (vitessio#16310)
88e8d1a 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@frouioui
Fix the install dependencies script in Docker (vitessio#16340)
2dd7702 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@kirtanchandak
Remove docker_local from Makefile (vitessio#16335)
81cec8c 
Signed-off-by: kirtanchandak <themarketingkirtan@gmail.com>
@mattrobenolt
go/mysql: performance optimizations in protocol encoding (vitessio#16341
d2d4caa 
)

Signed-off-by: Matt Robenolt <matt@ydekproductions.com>
@harshit-gangal
Cleanup: Health Stream removed db pool usage (vitessio#16336)
16670c9 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@frouioui @deepthi
Remove the bootstrap dependency on the Docker images we ship (vites…
9bb431a 
…sio#16339)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com>
@frouioui
Add release notes for the new connection drain (+ use dashes instead …
5154355 
…of underscore) (vitessio#16334)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@GuptaManan100
Remove unused parameters in reparent code and add CheckLockShard calls (
01fa9c8 
vitessio#16312)

Signed-off-by: Manan Gupta <manan@planetscale.com>
@systay
feat: remove ORDER BY from inside derived table (vitessio#16354)
231f434 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay @GuptaManan100
planner: Handle ORDER BY inside derived tables (vitessio#16353)
9d252b5 
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
@mattlord
VReplication: use new topo named locks and TTL override for workflow …
1099ed3 
…coordination (vitessio#16260)

Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattrobenolt
go/mysql: improve GTID encoding for OK packet (vitessio#16361)
3e8ef09 
Signed-off-by: Matt Robenolt <matt@ydekproductions.com>
@mattrobenolt
go/mysql: use clear builtin for zerofill (vitessio#16348)
e1849df 
Signed-off-by: Matt Robenolt <matt@ydekproductions.com>
@mattlord
VReplication: Handle large binlog compressed transactions more effici…
d5db4a8 
…ently (vitessio#16328)

Signed-off-by: Matt Lord <mattalord@gmail.com>
@frouioui
Fix echo command in build docker images workflow (vitessio#16350)
992b132 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@rohit-nayak-ps
VTAdmin: Show throttled status in workflows (vitessio#16308)
05370e0 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@shlomi-noach
Tablet throttler: multi-metric support (vitessio#15988)
8c339fc 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@harshit-gangal
rpc: retrieve unresolved transactions (vitessio#16356)
e0a705e 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@shlomi-noach
Throttler flaky test: explicitly disabling throttler so as to ensure …
3f6594e 
…it does not re-enable (vitessio#16369)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@brendar
VTCombo: Ensure VSchema exists when creating keyspace (vitessio#16094)
8ae9d38 
Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com>
frouioui and others added 3 commits September 30, 2024 15:33
@frouioui @mattlord
Fail fast when builtinbackup fails to restore a single file (vitessio…
8cd740f 
…#16856)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
Co-authored-by: Matt Lord <mattalord@gmail.com>
@mattlord
VReplication: Support both vindex col def formats when initing target…
db8fc31 
… sequences (vitessio#16862)

Signed-off-by: Matt Lord <mattalord@gmail.com>
@shlomi-noach
mysqld system metrics, with TabletManager rpc (vitessio#16850)
88982b0 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@dbussink dbussink force-pushed the dbussink/test-mysql-84-endtoend branch from b71dc37 to 5ca53e6 Compare October 2, 2024 09:08
mattlord and others added 3 commits October 2, 2024 15:40
@mattlord
CI: Lower resources used for TestVtctldMigrateSharded (vitessio#16875)
60835c9 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@GuptaManan100
Making Reshard work smoothly with Atomic Transactions (vitessio#16844)
698c63e 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
Fix: Errant GTID detection on the replicas when they set replication …
dcf5f3e 
…source (vitessio#16833)

Signed-off-by: Manan Gupta <manan@planetscale.com>
@dbussink dbussink force-pushed the dbussink/test-mysql-84-endtoend branch 2 times, most recently from 19b6663 to d325d6d Compare October 3, 2024 09:12
dbussink and others added 10 commits October 3, 2024 11:50
@dbussink
Allow for MySQL 8.4 in endtoend tests (vitessio#16885)
dcd63db
@systay @frouioui
upgrade vitess-tester to latest version (vitessio#16884)
27fdf3b 
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Fix golang upgrade workflow (vitessio#16890)
f3f34d8 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@timvaillancourt
Support specifying expected primary in ERS/PRS (vitessio#16852)
9326f40 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@deepthi
copy editing changes to summary (vitessio#16880)
230b033 
Signed-off-by: deepthi <deepthi@planetscale.com>
@mattlord
VReplication: Support automatically replacing auto_inc cols with sequ…
13d142f 
…ences (vitessio#16860)

Signed-off-by: Matt Lord <mattalord@gmail.com>
@dbussink
Test running endtoend against MySQL 8.4
33cdfcf 
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@dbussink
Try another find/replace
c89612c 
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@dbussink
Regenerate workflows
220c453 
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@dbussink
Allow non standard FK keys for stress tests
b3a85af 
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@dbussink dbussink force-pushed the dbussink/test-mysql-84-endtoend branch from d325d6d to c945186 Compare October 4, 2024 19:03
@vitess-bot vitess-bot modified the milestones: v21.0.0, v22.0.0 Oct 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. and removed Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. labels Nov 8, 2024
@harshit-gangal harshit-gangal force-pushed the dbussink/test-mysql-84-endtoend branch from c945186 to b3a85af Compare December 4, 2024 15:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Jan 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 will be requested when the pull request is marked ready for review GuptaManan100 is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui will be requested when the pull request is marked ready for review frouioui is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps will be requested when the pull request is marked ready for review rohit-nayak-ps is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi will be requested when the pull request is marked ready for review deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord will be requested when the pull request is marked ready for review mattlord is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal will be requested when the pull request is marked ready for review harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay will be requested when the pull request is marked ready for review systay is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach will be requested when the pull request is marked ready for review shlomi-noach is a code owner

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt timvaillancourt will be requested when the pull request is marked ready for review timvaillancourt is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins will be requested when the pull request is marked ready for review derekperkins is a code owner

@vmg vmg Awaiting requested review from vmg vmg will be requested when the pull request is marked ready for review vmg is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 will be requested when the pull request is marked ready for review ajm188 is a code owner

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit will be requested when the pull request is marked ready for review notfelineit is a code owner

Assignees
No one assigned
Labels
NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period.
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.