-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
throttler: formal gRPC calls in endtoend tests, removing HTTP API calls #16530
base: main
Are you sure you want to change the base?
Conversation
… API calls Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16530 +/- ##
=======================================
Coverage 67.52% 67.52%
=======================================
Files 1594 1595 +1
Lines 259564 259605 +41
=======================================
+ Hits 175266 175304 +38
- Misses 84298 84301 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…uch output Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…r response Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
|
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…tler/check' which is used by gh-ost and pt-osc Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@@ -70,7 +70,7 @@ const ( | |||
SchemaTrackerName Name = "schema-tracker" | |||
|
|||
TestingName Name = "test" | |||
TestingAlwaysThrottlerName Name = "always-throttled-app" | |||
TestingAlwaysThrottledName Name = "always-throttled-app" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo fix here.
This is now ready to review. |
Actually I see some more throttler API usage around the codebase, so taking this PR back to |
…p all usage Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Good to review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Description
For
v22
This PR removes any references to
/throttler/*
API calls, and uses gRPC instead.This is to be done in
v22
(right afterv21
is released) because someendtoend
tests and functionality is used in upgrade/downgrade testing and needs to keep supporting HTTP endpoints.Related Issue(s)
#15624
Checklist
Deployment Notes