Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic Transactions handling with Online DDL #16585

Merged
merged 14 commits into from
Aug 28, 2024

address review comments on doc

1f13e01
Select commit
Loading
Failed to load commit list.
Merged

Atomic Transactions handling with Online DDL #16585

address review comments on doc
1f13e01
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 27, 2024 in 1s

68.92% (-0.07%) compared to e6843dc

View this Pull Request on Codecov

68.92% (-0.07%) compared to e6843dc

Details

Codecov Report

Attention: Patch coverage is 73.18841% with 37 lines in your changes missing coverage. Please review.

Project coverage is 68.92%. Comparing base (e6843dc) to head (1f13e01).
Report is 6 commits behind head on main.

Files Patch % Lines
go/vt/vttablet/onlineddl/executor.go 6.25% 15 Missing ⚠️
go/vt/vttablet/tabletserver/tx_prep_pool.go 56.66% 13 Missing ⚠️
go/vt/vttablet/tabletserver/tx/api.go 78.94% 4 Missing ⚠️
go/vt/vttablet/tabletserver/dt_executor.go 85.71% 3 Missing ⚠️
go/vt/vttablet/tabletserver/tabletserver.go 81.81% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16585      +/-   ##
==========================================
- Coverage   68.99%   68.92%   -0.07%     
==========================================
  Files        1562     1562              
  Lines      200754   200850      +96     
==========================================
- Hits       138508   138435      -73     
- Misses      62246    62415     +169

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov