Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject TwoPC calls if semi-sync is not enabled #16608

Merged
merged 9 commits into from
Aug 23, 2024

feat: reuse the existing error code

b6208bd
Select commit
Loading
Failed to load commit list.
Merged

Reject TwoPC calls if semi-sync is not enabled #16608

feat: reuse the existing error code
b6208bd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 23, 2024 in 0s

68.98% (+0.00%) compared to 5458941

View this Pull Request on Codecov

68.98% (+0.00%) compared to 5458941

Details

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 68.98%. Comparing base (5458941) to head (b6208bd).
Report is 6 commits behind head on main.

Files Patch % Lines
go/vt/vttablet/tabletmanager/rpc_replication.go 0.00% 8 Missing ⚠️
go/vt/vttablet/tabletserver/tabletserver.go 0.00% 2 Missing ⚠️
go/vt/vttablet/tabletserver/dt_executor.go 50.00% 1 Missing ⚠️
go/vt/vttablet/tabletservermock/controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #16608   +/-   ##
=======================================
  Coverage   68.97%   68.98%           
=======================================
  Files        1562     1562           
  Lines      200673   200706   +33     
=======================================
+ Hits       138424   138449   +25     
- Misses      62249    62257    +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov