Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: json encoding on bind variables #16615

Closed
wants to merge 3 commits into from

test: add test expectation

068a651
Select commit
Loading
Failed to load commit list.
Closed

fix: json encoding on bind variables #16615

test: add test expectation
068a651
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 21, 2024 in 0s

68.87% (+0.10%) compared to 3c2e8f9

View this Pull Request on Codecov

68.87% (+0.10%) compared to 3c2e8f9

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.87%. Comparing base (3c2e8f9) to head (068a651).
Report is 15 commits behind head on main.

Files Patch % Lines
go/vt/vtgate/engine/insert_select.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16615      +/-   ##
==========================================
+ Coverage   68.77%   68.87%   +0.10%     
==========================================
  Files        1557     1562       +5     
  Lines      199826   200627     +801     
==========================================
+ Hits       137422   138178     +756     
- Misses      62404    62449      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.