CI: Use valid tag for the ossf-scorecard action

[mattlord]

Description

This is a quick follow-up to #16538. The workflow has been failing on main every time since it was merged with this error:

Error: Unable to resolve action `ossf/scorecard-action@v2`, unable to find version `v2`

That's because there are no major version tags (nor major.minor) used for this action: https://github.com/ossf/scorecard-action/tags

So this PR addresses that by using the latest version tag of v2.4.0.

Related Issue(s)

• Follow-up to: Added the scorecard github action and its badge #16538

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[deepthi]

Thank you!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.95%. Comparing base (5d562c7) to head (7945a82).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16730      +/-   ##
==========================================
+ Coverage   68.91%   68.95%   +0.03%     
==========================================
  Files        1565     1565              
  Lines      201685   201745      +60     
==========================================
+ Hits       138995   139105     +110     
+ Misses      62690    62640      -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.