Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChangeTabletTags RPC to vtctl, ChangeTags RPC to vttablet #16857

Merged
merged 7 commits into from
Oct 8, 2024

simplify summary

c77ab79
Select commit
Loading
Failed to load commit list.
Merged

Add ChangeTabletTags RPC to vtctl, ChangeTags RPC to vttablet #16857

simplify summary
c77ab79
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 7, 2024 in 0s

69.41% (-0.05%) compared to 056afc9

View this Pull Request on Codecov

69.41% (-0.05%) compared to 056afc9

Details

Codecov Report

Attention: Patch coverage is 40.82840% with 100 lines in your changes missing coverage. Please review.

Project coverage is 69.41%. Comparing base (056afc9) to head (c77ab79).

Files with missing lines Patch % Lines
go/cmd/vtctldclient/command/tablets.go 9.52% 19 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_actions.go 0.00% 15 Missing ⚠️
go/vt/vttablet/tmrpctest/test_tm_rpc.go 0.00% 12 Missing ⚠️
go/vt/vtcombo/tablet_map.go 0.00% 10 Missing ⚠️
go/vt/vttablet/grpctmclient/client.go 0.00% 9 Missing ⚠️
go/vt/vttablet/tabletmanager/tm_state.go 0.00% 8 Missing ⚠️
...t/vtctl/grpcvtctldserver/testutil/test_tmclient.go 61.11% 7 Missing ⚠️
go/vt/vttablet/grpctmserver/server.go 0.00% 7 Missing ⚠️
go/vt/topotools/tablet.go 84.61% 4 Missing ⚠️
go/vt/vtctl/grpcvtctldclient/client_gen.go 0.00% 4 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16857      +/-   ##
==========================================
- Coverage   69.45%   69.41%   -0.05%     
==========================================
  Files        1570     1570              
  Lines      203631   203798     +167     
==========================================
+ Hits       141441   141474      +33     
- Misses      62190    62324     +134

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov