Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-20.0] fixes bugs around expression precedence and LIKE (#16934 & #16649) #16946

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Oct 14, 2024

Description

This is a backport of #16934 and #16649

@vitess-bot vitess-bot bot added Backport This is a backport Component: Query Serving Merge Conflict Skip CI Skip CI actions from running Type: Bug labels Oct 14, 2024
Copy link
Contributor Author

vitess-bot bot commented Oct 14, 2024

Hello @systay, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 16946 -R vitessio/vitess
git reset --hard origin/release-20.0
git cherry-pick -m 1 0d5aaf31e1eaadf97add1eedab955d984f6fbb1d

Copy link
Contributor Author

vitess-bot bot commented Oct 14, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v20.0.3 milestone Oct 14, 2024
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
@systay systay removed Skip CI Skip CI actions from running Merge Conflict labels Oct 14, 2024
@systay systay force-pushed the backport-16934-to-release-20.0 branch from e7e29f5 to 22722b4 Compare October 14, 2024 12:36
@systay systay marked this pull request as ready for review October 14, 2024 12:37
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.69%. Comparing base (d744b20) to head (0e795c7).
Report is 1 commits behind head on release-20.0.

Files with missing lines Patch % Lines
go/vt/vtgate/evalengine/fn_string.go 91.66% 1 Missing ⚠️
go/vt/vtgate/evalengine/translate.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-20.0   #16946      +/-   ##
================================================
+ Coverage         68.66%   68.69%   +0.02%     
================================================
  Files              1541     1541              
  Lines            197984   197971      -13     
================================================
+ Hits             135952   135997      +45     
+ Misses            62032    61974      -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
@systay systay changed the title [release-20.0] fixes bugs around expression precedence and LIKE (#16934) [release-20.0] fixes bugs around expression precedence and LIKE (#16934 & #16649) Oct 15, 2024
@systay systay merged commit 0b2365e into release-20.0 Oct 15, 2024
185 checks passed
@systay systay deleted the backport-16934-to-release-20.0 branch October 15, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants