-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add missing tests for traffic_switcher.go
#17334
Conversation
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17334 +/- ##
==========================================
+ Coverage 67.48% 67.52% +0.04%
==========================================
Files 1577 1577
Lines 253424 253424
==========================================
+ Hits 171033 171135 +102
+ Misses 82391 82289 -102 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
err = ts.changeShardRouting(ctx) | ||
assert.NoError(t, err) | ||
|
||
sourceShardInfo, err := env.ws.ts.GetShard(ctx, sourceKeyspaceName, "0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, we should check IsPrimaryServing
before changeShardRouting
Description
Adds some unit tests to cover
traffic_switcher.go
Coverage diff:
Related Issue(s)
Checklist
Deployment Notes