Skip to content

[release-19.0] Use uint64 for binary log file position (#17472) #17505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2025

Fix test

84989f1
Select commit
Loading
Failed to load commit list.
Merged

[release-19.0] Use uint64 for binary log file position (#17472) #17505

Fix test
84989f1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 10, 2025 in 1s

65.20% (+0.01%) compared to 1b615f5

View this Pull Request on Codecov

65.20% (+0.01%) compared to 1b615f5

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.20%. Comparing base (1b615f5) to head (84989f1).

Files with missing lines Patch % Lines
go/mysql/binlog_event_common.go 0.00% 3 Missing ⚠️
go/vt/vtorc/inst/binlog.go 33.33% 2 Missing ⚠️
go/mysql/binlog_event_filepos.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #17505      +/-   ##
================================================
+ Coverage         65.19%   65.20%   +0.01%     
================================================
  Files              1560     1560              
  Lines            238326   238332       +6     
================================================
+ Hits             155380   155413      +33     
+ Misses            82946    82919      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.