Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LookupVindex: Multiple lookup tables support for LookupVindexCreate #17566

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

test: Add unit test for multiple lookup vindex create

447cf1b
Select commit
Loading
Failed to load commit list.
Open

LookupVindex: Multiple lookup tables support for LookupVindexCreate #17566

test: Add unit test for multiple lookup vindex create
447cf1b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 3, 2025 in 0s

67.71% (-0.06%) compared to 19890cf

View this Pull Request on Codecov

67.71% (-0.06%) compared to 19890cf

Details

Codecov Report

Attention: Patch coverage is 48.21429% with 174 lines in your changes missing coverage. Please review.

Project coverage is 67.71%. Comparing base (19890cf) to head (447cf1b).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
.../command/vreplication/lookupvindex/lookupvindex.go 1.98% 99 Missing ⚠️
go/vt/vtctl/workflow/lookup_vindex.go 66.36% 75 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17566      +/-   ##
==========================================
- Coverage   67.76%   67.71%   -0.06%     
==========================================
  Files        1585     1587       +2     
  Lines      255611   256061     +450     
==========================================
+ Hits       173217   173384     +167     
- Misses      82394    82677     +283     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.