Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: set 16 core runners to oci gh arc runners #17879

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeefy
Copy link

@jeefy jeefy commented Feb 28, 2025

Description

CNCF has hosted ephemeral GitHub runners in Oracle that we're wanting projects to use rather than the GitHub hosted ones, which are now incur a cost to use. This PR is currently a WIP to work through any tests that break or dependencies that may be missing. <3

Please direct any questions to myself, @krook and @RobertKielty

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Feb 28, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 28, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Feb 28, 2025
@frouioui frouioui added Type: Internal Cleanup Component: Build/CI and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 3, 2025
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there is a consistent failure:

Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
Executing: /tmp/apt-key-gpghome.EVGkbtO7nh/gpg.1.sh --keyserver keyserver.ubuntu.com --recv-keys A8D3785C
gpg: error running '/usr/bin/dirmngr': probably not installed
gpg: failed to start the dirmngr '/usr/bin/dirmngr': Configuration error
gpg: connecting dirmngr at '/tmp/apt-key-gpghome.EVGkbtO7nh/S.dirmngr' failed: Configuration error
gpg: keyserver receive failed: No dirmngr

When installing dependencies, specifically this:

        # Get key to latest MySQL repo
        sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-keys A8D3785C
        # Setup MySQL 8.0
        wget -c https://dev.mysql.com/get/mysql-apt-config_0.8.33-1_all.deb
        echo mysql-apt-config mysql-apt-config/select-server select mysql-8.0 | sudo debconf-set-selections
        sudo DEBIAN_FRONTEND="noninteractive" dpkg -i mysql-apt-config*
        sudo apt-get -qq update

@RobertKielty
Copy link

RobertKielty commented Mar 4, 2025

@frouioui thank you for letting us know. I will look at this now.

Edit : @jeefy added dirmngr on this cncf/automation#53 to the image which fixed the error that you reported.

We can see the workflow getting the key to the latest MySQL key repohere

https://github.com/vitessio/vitess/actions/runs/13595155407/job/38013879979#step:9:38

Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
Executing: /tmp/apt-key-gpghome.eOoDPYePG2/gpg.1.sh --keyserver keyserver.ubuntu.com --recv-keys A8D3785C
gpg: key B7B3B788A8D3785C: public key "MySQL Release Engineering <mysql-build@oss.oracle.com>" imported
gpg: Total number processed: 1
gpg:               imported: 1
--2025-02-28 20:52:23--  https://dev.mysql.com/get/mysql-apt-config_0.8.33-1_all.deb
Resolving dev.mysql.com (dev.mysql.com)... 23.5.250.172, 2600:1406:3a00:291::2e31, 2600:1406:3a00:296::2e31
Connecting to dev.mysql.com (dev.mysql.com)|23.5.250.172|:443... connected.
HTTP request sent, awaiting response... 302 Moved Temporarily
Location: https://repo.mysql.com//mysql-apt-config_0.8.33-1_all.deb [following]
--2025-02-28 20:52:23--  https://repo.mysql.com//mysql-apt-config_0.8.33-1_all.deb
Resolving repo.mysql.com (repo.mysql.com)... 23.[36](https://github.com/vitessio/vitess/actions/runs/13595155407/job/38013879979#step:9:37).90.21, 2600:1406:2e00:89c::1d68, 2600:1406:2e00:880::1d68
Connecting to repo.mysql.com (repo.mysql.com)|23.36.90.21|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 18072 (18K) [application/x-debian-package]
Saving to: 'mysql-apt-config_0.8.33-1_all.deb'

     0K .......... .......                                    100%  100M=0s

The error that we are now seeing is at Get dependencies step
https://github.com/vitessio/vitess/actions/runs/13595155407/job/38013879979#step:9:944

update-alternatives: warning: skip creation of /usr/share/man/man1/c++.1.gz because associated file /usr/share/man/man1/g++.1.gz (of link group c++) doesn't exist
Processing triggers for libc-bin (2.35-0ubuntu3.8) ...
mysql: unrecognized service

@jeefy jeefy force-pushed the cncf-hosted-runners branch 3 times, most recently from 4f337bd to 195ec29 Compare March 4, 2025 19:07
@jeefy
Copy link
Author

jeefy commented Mar 4, 2025

Looks like all but one test is consistently passing. Ran into an interesting scaling issue with ARC/K8s and disk pressure causing flakes because the runner pod was getting evicted.

Don't know why that last one is failing, but I suspect it's some difference in environments still.

@shlomi-noach
Copy link
Contributor

The failing tests in onlineddl_vrepl_suite are consistent. These are always:

2025-03-04T23:30:46.7729927Z     --- FAIL: TestVreplSuiteSchemaChanges/alter-charset-non-utf8 (2.05s)
2025-03-04T23:30:46.7730602Z     --- FAIL: TestVreplSuiteSchemaChanges/alter-charset-non-utf8-80 (3.04s)
2025-03-04T23:30:46.7731328Z     --- FAIL: TestVreplSuiteSchemaChanges/alter-charset-non-utf8-80-vcopier (2.03s)

Failing with this error:

vreplication: terminal error: task error: failed inserting rows: Incorrect string value: Cannot convert string "átesting" from latin1 to latin2 (errno 1366) (sqlstate HY000)

The runners are using mysql 8.0.41, same version as our standard runners. I'm not sure if there's any environment change here, as our standard runners are perfectly happy with the test (example).

@jeefy jeefy force-pushed the cncf-hosted-runners branch from 195ec29 to c223498 Compare March 5, 2025 18:54
Signed-off-by: Jeffrey Sica <me@jeefy.dev>
@jeefy jeefy force-pushed the cncf-hosted-runners branch from c223498 to 535a671 Compare March 5, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants