Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestTrackerNoLock flaky test by increasing time to mark failure #17886

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Fix TestTrackerNoLock flaky test by increasing time to mark failure #17886

merged 1 commit into from
Mar 3, 2025

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Mar 3, 2025 •
edited
Loading

Description

The Test was introduced in PR #17873.
This needs to be backported till v20 to have flaky fixes in all branches.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@harshit-gangal
increase wait time to fail the test
83b5a0d 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 3, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 3, 2025
@harshit-gangal harshit-gangal added Component: Query Serving Type: Testing and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 3, 2025
@frouioui frouioui added Backport to: release-20.0 Needs to be backport to release-20.0 Backport to: release-21.0 Needs to be backport to release-21.0 labels Mar 3, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Mar 3, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.51%. Comparing base (0af627a) to head (83b5a0d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #17886   +/-   ##
=======================================
  Coverage   67.51%   67.51%           
=======================================
  Files        1595     1595           
  Lines      259640   259640           
=======================================
+ Hits       175292   175308   +16     
+ Misses      84348    84332   -16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

deepthi
deepthi approved these changes Mar 3, 2025
View reviewed changes
go/vt/vtgate/schema/tracker_test.go
@@ -194,7 +194,7 @@ func TestTrackerNoLock(t *testing.T) {
for i := 0; i < 500000; i++ {
select {
case ch <- th:
case <-time.After(5 * time.Millisecond):
case <-time.After(10 * time.Millisecond):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No guarantee that this will not be flaky even then. We should look at the new synctest package in 1.24 to see if that can be used to reduce flakiness in tests that depend on time. We can approve and merge for now.

https://go.dev/blog/synctest

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can look into for main. This needs to be ported to v20 and v21.

@deepthi deepthi merged commit 41a8d1d into vitessio:main Mar 3, 2025
117 checks passed
@deepthi deepthi deleted the trackerNoLock-flaky branch March 3, 2025 17:55
This was referenced Mar 3, 2025
Closed
Closed
harshit-gangal added a commit that referenced this pull request Mar 4, 2025
@harshit-gangal
Fix TestTrackerNoLock flaky test by increasing time to mark failure (#…
053512d 
…17886)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal added a commit that referenced this pull request Mar 4, 2025
@harshit-gangal
Fix TestTrackerNoLock flaky test by increasing time to mark failure (#…
1fa46c8 
…17886)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@frouioui frouioui frouioui approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

Assignees
No one assigned
Labels
Backport to: release-20.0 Needs to be backport to release-20.0 Backport to: release-21.0 Needs to be backport to release-21.0 Component: Query Serving Type: Testing
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@harshit-gangal @deepthi @frouioui