Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip - dirty implementation of findRoute for Values #17899

Closed
wants to merge 1 commit into from

Conversation

systay
Copy link
Collaborator

@systay systay commented Mar 4, 2025

Signed-off-by: Florent Poinsard florent.poinsard@outlook.fr

Finalize the Values OpCode and TestFindRouteValuesJoin

Signed-off-by: Florent Poinsard florent.poinsard@outlook.fr

Use MultiEqual instead of Values OpCode

Signed-off-by: Florent Poinsard florent.poinsard@outlook.fr

Remove routing multi equal optimization

Signed-off-by: Florent Poinsard florent.poinsard@outlook.fr

Add VALUES operator and SQL_builder bit

Signed-off-by: Florent Poinsard florent.poinsard@outlook.fr

Add the ValuesJoin operator and SQL_builder test

Signed-off-by: Florent Poinsard florent.poinsard@outlook.fr

Rename SQL_builder -> op_to_ast

Signed-off-by: Florent Poinsard florent.poinsard@outlook.fr

add logic for splitting expressions

Signed-off-by: Andres Taylor andres@planetscale.com

offset planning for ValuesJoin

Signed-off-by: Florent Poinsard florent.poinsard@outlook.fr

feat: change the value-join to have a RowID mode

Signed-off-by: Florent Poinsard florent.poinsard@outlook.fr

Use ROW_TUPLE and simplify planOffsets

Signed-off-by: Florent Poinsard florent.poinsard@outlook.fr

Make sure Values operator conserve the table qualifier

Signed-off-by: Florent Poinsard florent.poinsard@outlook.fr

Revert changes to onecase

Signed-off-by: Florent Poinsard florent.poinsard@outlook.fr

Addition of a macro benchmark for values join

Signed-off-by: Florent Poinsard florent.poinsard@outlook.fr

Add comment directive to enable values joins and more benchmarks

Signed-off-by: Florent Poinsard florent.poinsard@outlook.fr

change to rewriting apply joins in later phases instead of creating the value joins up front - wip

Signed-off-by: Andres Taylor andres@planetscale.com

add columns before predicates

Signed-off-by: Andres Taylor andres@planetscale.com

refactor: change how we handle Values and ValuesJoin planning - wip

Signed-off-by: Andres Taylor andres@planetscale.com

feat: fix pushing of values and filters to a value join

Signed-off-by: Manan Gupta manan@planetscale.com

wip

Signed-off-by: Florent Poinsard florent.poinsard@outlook.fr

wip

Description

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Finalize the Values OpCode and TestFindRouteValuesJoin

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Use MultiEqual instead of Values OpCode

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Remove routing multi equal optimization

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Add VALUES operator and SQL_builder bit

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Add the ValuesJoin operator and SQL_builder test

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Rename SQL_builder -> op_to_ast

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

add logic for splitting expressions

Signed-off-by: Andres Taylor <andres@planetscale.com>

offset planning for ValuesJoin

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

feat: change the value-join to have a RowID mode

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Use ROW_TUPLE and simplify planOffsets

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Make sure Values operator conserve the table qualifier

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Revert changes to onecase

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Addition of a macro benchmark for values join

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Add comment directive to enable values joins and more benchmarks

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

change to rewriting apply joins in later phases instead of creating the value joins up front - wip

Signed-off-by: Andres Taylor <andres@planetscale.com>

add columns before predicates

Signed-off-by: Andres Taylor <andres@planetscale.com>

refactor: change how we handle Values and ValuesJoin planning - wip

Signed-off-by: Andres Taylor <andres@planetscale.com>

feat: fix pushing of values and filters to a value join

Signed-off-by: Manan Gupta <manan@planetscale.com>

wip

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

wip
Copy link
Contributor

vitess-bot bot commented Mar 4, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 4, 2025
@systay systay closed this Mar 4, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants