Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for specifying a specific MySQL shutdown timeout #17923

Capitalize

5be710b
Select commit
Loading
Failed to load commit list.
Merged

Allow for specifying a specific MySQL shutdown timeout #17923

Capitalize
5be710b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 10, 2025 in 0s

67.54% (-0.02%) compared to a3a52c0

View this Pull Request on Codecov

67.54% (-0.02%) compared to a3a52c0

Details

Codecov Report

Attention: Patch coverage is 45.76271% with 32 lines in your changes missing coverage. Please review.

Project coverage is 67.54%. Comparing base (a3a52c0) to head (5be710b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtctl/backup.go 0.00% 15 Missing ⚠️
go/cmd/vtctldclient/command/backups.go 18.75% 13 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_backup.go 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17923      +/-   ##
==========================================
- Coverage   67.56%   67.54%   -0.02%     
==========================================
  Files        1597     1597              
  Lines      259782   259810      +28     
==========================================
- Hits       175516   175491      -25     
- Misses      84266    84319      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.