-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add TMC RPCs for updating sequences for switchwrites
#18172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TMC RPCs for updating sequences for switchwrites
#18172
Conversation
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
301f2d9
to
b1a5d19
Compare
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18172 +/- ##
==========================================
- Coverage 67.55% 67.50% -0.06%
==========================================
Files 1601 1601
Lines 261424 261576 +152
==========================================
- Hits 176599 176570 -29
- Misses 84825 85006 +181 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
repeated SequenceMetadata sequences = 1; | ||
} | ||
|
||
message GetMaxValueForSequencesResponse { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a comment here about what this map's key is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
Signed-off-by: Noble Mittal <noblemittal@outlook.com>
Description
This PR adds 2 TMC RPCs:
GetMaxValueForSequences
: Gets the max used sequence value mapped with the provided backing sequence tables.UpdateSequenceTables
: Updates all the sequence tables listed in the request, with the max value provided in the sequence metadata.Instead of separate RPC calls for each table per shard, these 2 RPCs allow it to reduce to just 1 RPC call (all tables at once) per shard for fetching and updating max sequence value each.
Related Issue(s)
Checklist
Deployment Notes