Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spy): clear/reset/restore mocks in stack order #7499

Merged

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Feb 15, 2025

Description

This PR reverts spy reuse idea of #6464 and fixes the original issue #6419 with a different approach. By reversing the order of restoreAllMocks, it can restore the original method.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Feb 15, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c76b0fd
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67b51ef0923a230008240226
😎 Deploy Preview https://deploy-preview-7499--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa marked this pull request as ready for review February 15, 2025 07:32
Copy link

pkg-pr-new bot commented Feb 16, 2025

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@7499

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@7499

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@7499

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@7499

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@7499

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@7499

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@7499

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@7499

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@7499

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@7499

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@7499

vite-node

npm i https://pkg.pr.new/vite-node@7499

vitest

npm i https://pkg.pr.new/vitest@7499

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@7499

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@7499

commit: c76b0fd

@hi-ogawa hi-ogawa merged commit f71004f into vitest-dev:main Feb 19, 2025
14 checks passed
@hi-ogawa hi-ogawa deleted the fix-restore-mock-all-in-stack-order branch February 19, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Create spyReset to only reset spies, not other mocks
2 participants