Tentative 0.1.0 release PR #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we didn't consider the first Vers entry as a proper entry, matching Swifty behavior.
It was an issue with my connection. Things can be improved by using threading / async but that's beyond the current scope
Still needs some improvement but we've ditched Whatever errors and a bunch of unwraps
Swifty uses .NET's InvariantCulture IgnoreCase string comparison. I don't know of an easy way to exactly reimplement it in Rust, but for certain edge cases (i.e files which begin with numbers) folding to uppercase works. This will probably break again in the future.
vitorhnn
force-pushed
the
wip
branch
3 times, most recently
from
44c4e3f to
a723575
Compare
|
Congrats, Wish you luck! |
Small helper to deserialize MD5 digests to an array of u8. Simplifies handling the lifetimes of some HashSets we will be building in later commits
downloading Previously if a download failed we'd leave a partially downloaded file behind, which frequently crashed us when we parsed it later. Change it so we first download into a temp file and then copy to the location it's supposed to be. This might help with the implementation of delta downloads later, idk
This allows us to use the checksums in repo.json, the first file we download, to skip mods with matching checksums, allowing us to not download mods' mod.srf
yes this should've been split.
Windows users: please use a text editor that doesn't require autocrlf
Will be used for the launch command
vitorhnn
force-pushed
the
wip
branch
3 times, most recently
from
e2a6183 to
5c35c9a
Compare
steam protocol is horribly unreliable. might have to launch game directly.
vitorhnn
force-pushed
the
wip
branch
2 times, most recently
from
a3393ce to
d375b05
Compare
Some of these could reasonably be removed, but they don't cost us much to keep around anyway.
* Remove goals and TODO list, will be moved over to issues. * Add install instructions. * Add usage instructions.
Or, as the docs put it "wow shiny new dist CI!" :)
Owner
Author
|
This isn't perfect by any means, but after two years dogfooding this I think it's good enough to get a 0.1.0 release out there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
launchcommandsteam://URLs on both Linux and Windows, so this will only be reliable if Steam is launched through nimble.