feat: Improved __init__.py for skeletons and modules
#137
Conversation
This PR changes the current __init__.py-scripts to allow for module- and skeleton restructuring using folders. - `skeletons/__init__.py` imports skeletons from any sub-folders now - `modules/__init__.py` imports modules from any sub-folder, but registers them as they where defined just in modules, so there's no prefixing like before. As the latter one "breaks" a current behavior, IMHO this was only requested for the viur-shop module and was solved differently there, as there is a `Shop()`-module which is imported.
phorward
added
feature
There was a problem hiding this comment.
I basically don't care what the recursive behavior is. I have the importer in my projects so that the order structure simply acts as a grouping of the modules for a better overview, but does not cause any name changes.
In the end, everyone has their own expectations as to how they would like this to work in their project or how it fits there.
I would be interested to hear @KadirBalku 's opinion, as he implemented it that way back then in #112.
Otherwise, the behavior would be okay for me.
I just think the technical implementation is a step backwards. Why are you using this old fashion os lib again, but still handling path objects? Please use the pathlib consistently. I think you can save yourself these __find_py_files completely if you simply use directory.rglob("*.py"). You would only have to do the blacklist manually.
| for name, obj in inspect.getmembers(__module, inspect.isclass): | ||
| if issubclass(obj, __viur_Module) and obj.__module__ == __module.__name__: | ||
| # Import the class into the current namespace | ||
| print(name.lower(), obj) |
There was a problem hiding this comment.
Please don't use print and use the logging framework.
Even if it is not established, maybe also a custom logger
log = logging.getLogger("my-project").getChild(__name__).getChild("autoloader")Using the root logger is actually mostly a bad idea, but that's another problem in ViUR and ViUR projects ...
sveneberth
added
the
waiting-for-changes
This PR changes the current
__init__.py-scripts to allow for module- and skeleton restructuring using folders.skeletons/__init__.pyimports skeletons from any sub-folders nowmodules/__init__.pyimports modules from any sub-folder, but registers them as they where defined just in modules, so there's no prefixing like before.As the latter one "breaks" a current behavior, IMHO this was only requested for the viur-shop module and was solved differently there, as there is a
Shop()-module which is imported.