-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COM-964 Add multiselect to choose test contacts (Depends on: #78) #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1c9cc5
to
14293f8
Compare
14293f8
to
fbd842d
Compare
29d628e
to
f2321fe
Compare
f2321fe
to
76b0b6a
Compare
packages/admin/src/emailCampaigns/form/TestEmailCampaignForm.tsx
Outdated
Show resolved
Hide resolved
Merged
raphaelblum
reviewed
Dec 17, 2024
packages/admin/src/emailCampaigns/form/TestEmailCampaignForm.tsx
Outdated
Show resolved
Hide resolved
|
raphaelblum
approved these changes
Jan 15, 2025
RainbowBunchie
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, there is a text field for entering test contacts manually.
The email dispatch only works if the entered email is part of a contact list. To resolve this, the textfield is replaced with a multi-select field that only displays users from the test contact list.
Changes:
Replaced the free-text field with a multi-select field.
The multi-select field is now populated with users from the test contact list only.
Screenshots/screencasts
Changeset
[x] I have verified if my change requires a changeset
Further information
https://vivid-planet.atlassian.net/browse/COM-964