Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image block #253

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Conversation

juliawegmayr
Copy link
Contributor

@juliawegmayr juliawegmayr commented Dec 17, 2024

Description

  • Setup for generate-block-types
  • Add NewsLetterImageBlock

Changeset

Changeset will be added to the feature branch

Related tasks and documents

https://vivid-planet.atlassian.net/browse/COM-1034

Open TODOs/questions

Further information

Styling of NewsletterImageBlock will be done in an upcoming PR.

Depends on: #223

@juliawegmayr juliawegmayr added this to the v3 milestone Dec 17, 2024
@juliawegmayr juliawegmayr force-pushed the add-image-block branch 8 times, most recently from 630bf52 to bb91cd1 Compare December 18, 2024 10:27
@juliawegmayr juliawegmayr self-assigned this Dec 18, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@juliawegmayr juliawegmayr changed the base branch from next to feature/mail-rendering-package December 19, 2024 11:02
@juliawegmayr juliawegmayr marked this pull request as ready for review December 19, 2024 11:03
@auto-assign auto-assign bot requested a review from raphaelblum December 19, 2024 11:03
@juliawegmayr juliawegmayr mentioned this pull request Jan 2, 2025
1 task
install.sh Outdated Show resolved Hide resolved
packages/api/generate-block-meta.ts Outdated Show resolved Hide resolved
packages/api/src/blocks/newsletter-image.block.ts Outdated Show resolved Hide resolved
@juliawegmayr juliawegmayr merged commit aae093b into feature/mail-rendering-package Jan 15, 2025
1 check failed
@juliawegmayr juliawegmayr deleted the add-image-block branch January 15, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants