Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Comet v6 #40

Merged
merged 29 commits into from
May 27, 2024
Merged

Update to Comet v6 #40

merged 29 commits into from
May 27, 2024

Conversation

stekalt
Copy link
Contributor

@stekalt stekalt commented May 6, 2024 •
edited by thomasdax98
Loading

Breaking Changes:

  • Now requires >= v6.0.0 for @comet packages

API:

  • All GraphQL resolvers now require the brevo-newsletter permission.
  • BrevoContactResolver#subscribeBrevoContact mutation: The scope argument was moved outside input to enable an automatic scope check
  • BrevoContactsService#createDoubleOptInContact: scope was moved outside data and is now the second argument
  • TargetGroupsService#findNonMainTargetGroups: data was replaced with scope

COM-708

thomasdax98 and others added 18 commits May 2, 2024 15:24
@thomasdax98
Update comet package versions to v6
93ae117
@thomasdax98
Rename @SubjectEntity to @AffectedEntity
34c2e8d
@thomasdax98
Disable eslint rule @comet/no-other-module-relative-import
dc57cf1
Remove custom CurrentUser and CurrentUserLoader
2043b5b
Create the AccessControlService for the UserPermissionsModule
3aba5d6
Replace ContentScopeModule with UserPermissionsModule
e665fb2
Adapt decorators: Add @RequiredPermission to resolvers and controllers
dd8a843
Add <CurrentUserProvider> to App.tsx
edf4d83
Use useCurrentUser() hook instead requesting the current user from th…
a057090 
…e API
Add the Adminstration Panel
8770b5f
Remove ProductsAclService
6245a19
Add array of contentScopes to UserPermissionsModule
ff9a35a
Remove unnecessary code
85be846
Adapt decorators: Add correct permissions to resolver
ca15ac2
Define and use type of sites config
7c477aa
Remove type annotation from ContentScopeProvider#resolveSiteConfigFor…
99d1528 
…Scope
Replace onAfterSubmit workarounds
79196e4
Add changeset
a5acb87
@stekalt stekalt requested a review from thomasdax98 May 6, 2024 13:33
@stekalt stekalt self-assigned this May 6, 2024
@auto-assign auto-assign bot requested a review from raphaelblum May 6, 2024 13:33
@stekalt stekalt marked this pull request as draft May 6, 2024 13:35
@thomasdax98 thomasdax98 marked this pull request as ready for review May 7, 2024 14:59
@auto-assign auto-assign bot requested a review from raphaelblum May 7, 2024 14:59
@thomasdax98 thomasdax98 requested review from johnnyomair and removed request for johnnyomair May 7, 2024 14:59
@RainbowBunchie RainbowBunchie mentioned this pull request May 13, 2024
Merged
@johnnyomair
Copy link
Collaborator

@thomasdax98 should I review this PR or @raphaelblum?

raphaelblum
raphaelblum reviewed May 23, 2024
View reviewed changes
.changeset/shaggy-feet-live.md Show resolved Hide resolved
.env Show resolved Hide resolved
packages/api/.eslintrc.json Show resolved Hide resolved
@thomasdax98 thomasdax98 self-assigned this May 23, 2024
@thomasdax98 thomasdax98 requested a review from raphaelblum May 23, 2024 11:19
@thomasdax98 thomasdax98 merged commit 166ac36 into main May 27, 2024
1 check passed
@thomasdax98 thomasdax98 deleted the update-v6 branch May 27, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasdax98 thomasdax98 thomasdax98 left review comments

@RainbowBunchie RainbowBunchie RainbowBunchie left review comments

@raphaelblum raphaelblum raphaelblum approved these changes

@johnnyomair johnnyomair johnnyomair approved these changes

Assignees

@thomasdax98 thomasdax98

@stekalt stekalt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stekalt @johnnyomair @thomasdax98 @RainbowBunchie @raphaelblum