Update code for Java12 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awoods
reviewed
Jan 26, 2020
| @@ -63,7 +63,7 @@ | |||
| <property name="test.home" value="${top.dir}/test" /> | |||
| <property name="test.lib" value="${test.home}/lib" /> | |||
| <property name="junit.jar" value="${test.lib}/junit.jar" /> | |||
| <property name="target.version" value="1.6"/> | |||
| <property name="target.version" value="1.7"/> | |||
There was a problem hiding this comment.
It looks like you are targeting "java 7"... as opposed to "java 12".
My standard JVM these days is the LTS java 11... which results in a build failure on this pull-request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made to code to get it to run on MacOS Catalina, openjdk 12.
Use build.xml to build VUE to a jar. Run the jar using: