Avoid lock on graph uri update (VIVO-3885) #395
Merged
+58
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenejac
previously approved these changes
Jun 12, 2023
There was a problem hiding this comment.
@litvinovg I don't see any significant delay anymore (I tried with 1M+ triplets). So, it looks it works for me.
…ad to update graph uris has been already created.
brianjlowe
approved these changes
Jun 16, 2023
|
@chenejac Wasn't sure if your comment counts as an approval. If so, this should be ready to be merged. |
|
Yes, I approved the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue
What does this pull request do?
Run graph uri update in a separate thread to avoid lock
How should this be tested?
Test as in issue description:
Interested parties
@VIVO-project/vivo-committers @chenejac @brianjlowe