refactor: UI Improvements And Archived Bookmarks Fetching #19
vkhitrinAnnotations
6 warnings
|
lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
variant name ends with the enum's name:
src/main.rs#L81
warning: variant name ends with the enum's name
--> src/app.rs:81:5
|
81 | EmpptyMessage,
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
= note: `#[warn(clippy::enum_variant_names)]` on by default
|
|
large size difference between variants:
src/main.rs#L118
warning: large size difference between variants
--> src/app.rs:118:1
|
118 | / pub enum DialogPage {
119 | | RemoveAccount(Account),
| | ---------------------- the second-largest variant contains at least 104 bytes
120 | | RemoveBookmark(Account, Bookmark),
| | --------------------------------- the largest variant contains at least 448 bytes
121 | | }
| |_^ the entire enum is at least 448 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
120 | RemoveBookmark(Account, Box<Bookmark>),
| ~~~~~~~~~~~~~
|
|
this function has too many arguments (17/7):
src/main.rs#L26
warning: this function has too many arguments (17/7)
--> src/models/bookmarks.rs:26:5
|
26 | / pub fn new(
27 | | account_id: Option<i64>,
28 | | linkding_id: Option<i64>,
29 | | linkding_url: String,
... |
43 | | linkding_date_modified: Option<String>,
44 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
src/main.rs#L327
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> src/pages/bookmarks.rs:327:15
|
327 | accounts: &'b Vec<Account>,
| ^^^^^^^^^^^^^^^^ help: change this to: `&'b [Account]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
src/main.rs#L398
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> src/pages/bookmarks.rs:398:60
|
398 | pub fn edit_bookmark<'a, 'b>(bookmark: Bookmark, accounts: &'b Vec<Account>) -> Element<'a, Message>
| ^^^^^^^^^^^^^^^^ help: change this to: `&'b [Account]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
|