Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Adding Initial CI #3

Merged
merged 1 commit into from
Oct 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
name: Build

on:
pull_request:
branches:
- main

env:
CARGO_TERM_COLOR: always

jobs:
build:
runs-on: ubuntu-latest
steps:
- name: Install depencencies
run: sudo apt-get install -y libxkbcommon-dev libsqlite3-dev
- name: Configure rust-toolchain
uses: dtolnay/rust-toolchain@stable
with:
components: rustfmt
- name: Checkout
uses: actions/checkout@v4
- name: Build
run: cargo build --verbose
35 changes: 35 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
---
name: Lint

on:
pull_request:
branches:
- main

env:
CARGO_TERM_COLOR: always

jobs:
lint:
runs-on: ubuntu-latest
permissions:
checks: write
pull-requests: write
steps:
- name: Install depencencies
run: sudo apt-get install -y libxkbcommon-dev libsqlite3-dev
- name: Configure rust-toolchain
uses: dtolnay/rust-toolchain@nightly
with:
components: rustfmt,clippy
- name: Checkout
uses: actions/checkout@v4
- name: Lint using clippy
uses: auguwu/clippy-action@1.4.0
with:
token: ${{ secrets.GITHUB_TOKEN }}
- name: Format
uses: mbrobbel/rustfmt-check@master
with:
token: ${{ secrets.GITHUB_TOKEN }}
mode: review
29 changes: 2 additions & 27 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
> [!CAUTION]
> This application is still under development, and is not deemed stable for general use.

<p align="center">
<img alt="cosmicding logo" src="./res/icons/hicolor/256x256/apps/com.vkhitrin.cosmicding.png" alt="Logo" height="192px" width="192px">
</p>
Expand Down Expand Up @@ -30,7 +27,7 @@ Features:
- `just`
- `libxkbcommon-dev`
- `libcosmic`
- `libsqlite3`
- `libsqlite3-dev`

## Installation

Expand All @@ -52,29 +49,6 @@ sudo just install

## Roadmap

### Initial Stable Release

> [!NOTE]
> This list is not complete and subject to change.

In preparation for the first initial "stable" release, the following must be completed:

- [x] [Application] Throw exceptions when failed to invoke REST API requests.
- [x] [UI] Notifications/toasts.
- [x] Account deletion.
- [x] Updating account.
- [x] Adding account.
- [x] Refreshing bookmarks for account.
- [x] Refreshing bookmarks for all accounts.
- [x] Bookmark deletion.
- [x] Updating bookmark.
- [x] Adding bookmark.
- [x] [Application] logging.
- [x] [Application] Avoid refreshing on every change/update.
- [x] Update memory in-place when possible.
- [x] [Application] "Lazy" bookmark refresh (do not block).
- [ ] CI

### Future

Potential improvements:
Expand All @@ -88,6 +62,7 @@ Potential improvements:
- [UI] Visual indicator for last sync status.
- [UI] Indicators for `archived`, `unread`, `shared` bookmarks.
- [Distribution] Flatpack release.
- [Distribution] compiled binary in GitHub release.
- [UI] Sort bookmarks.

Things to consider:
Expand Down
Binary file modified res/screenshots/accounts.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified res/screenshots/bookmarks.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion src/key_binds.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
use std::collections::HashMap;

use cosmic::iced::keyboard::Key;
use cosmic::widget::menu::key_bind::KeyBind;
use cosmic::widget::menu::key_bind::Modifier;
use cosmic::iced::keyboard::Key;

use crate::app::MenuAction;

Expand Down
4 changes: 2 additions & 2 deletions src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
mod db;
mod http;
mod i18n;
mod key_binds;
mod menu;
mod models;
mod nav;
mod pages;
mod key_binds;

use crate::config::{Config, CONFIG_VERSION};
use cosmic::cosmic_config::{self, CosmicConfigEntry};
use app::{Flags, APPID};
use cosmic::cosmic_config::{self, CosmicConfigEntry};

fn main() -> cosmic::iced::Result {
let requested_languages = i18n_embed::DesktopLanguageRequester::requested_languages();
Expand Down
4 changes: 1 addition & 3 deletions src/menu.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@ pub fn menu_bar<'a>(key_binds: &HashMap<KeyBind, MenuAction>) -> Element<'a, Mes
root(fl!("file")),
items(
key_binds,
vec![
Item::Button(fl!("add-account"), MenuAction::AddAccount),
],
vec![Item::Button(fl!("add-account"), MenuAction::AddAccount)],
),
),
Tree::with_children(
Expand Down