Skip to content

db.mysql: use hardcoded const declare #24162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

db.mysql: use hardcoded const declare #24162

merged 1 commit into from
Apr 9, 2025

Conversation

kbkpbot
Copy link
Contributor

@kbkpbot kbkpbot commented Apr 8, 2025 •
edited by huly-for-github bot
Loading

Fix issue #22086

@huly-for-github Huly for GitHub
Copy link

Connected to Huly®: V_0.6-22551

@JalonSolov
Copy link
Contributor

Nice. One less C header to deal with. The file should also be renamed to just consts.v since there are no more C. references.

Final suggestion: add end of line comments showing the C constant, for continuity.

spytheman
spytheman approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit aba4a5a into vlang:master Apr 9, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbkpbot @JalonSolov @spytheman