-
Notifications
You must be signed in to change notification settings - Fork 261
[Qwen3Next] Add FP8 Quantization Example #1886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: shanjiaz <zsjwpianpian@gmail.com>
Summary of ChangesHello @shanjiaz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new example that showcases the application of FP8 dynamic quantization to the Qwen3-Next-80B-A3B-Instruct model using the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new example script for FP8 quantization of the Qwen3-Next model. The script is well-structured and follows existing patterns. My main feedback is to improve the clarity of the quantization recipe by adding comments to explain why a large number of modules are being ignored, as this is not standard practice and could be confusing for users referencing this example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment, otherwise LGTM
Signed-off-by: shanjiaz <zsjwpianpian@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: shanjiaz <zsjwpianpian@gmail.com>
Hello!
Thank you. |
SUMMARY: Added qwen3 next fp8 quantization example. Model produced is uploaded [here](https://huggingface.co/shanjiaz/qwen3-80b-fp8-dynamic) TEST PLAN: Tested locally. --------- Signed-off-by: shanjiaz <zsjwpianpian@gmail.com> Signed-off-by: Cassie Jeon <cajeon@redhat.com>
SUMMARY: - Need to update links when the following PRs land: 1. vllm-project#1886 2. vllm-project#1874 3. vllm-project#1889 Signed-off-by: Cassie Jeon <cajeon@redhat.com>
@ng-blip Thanks for reaching out!
|
SUMMARY:
Added qwen3 next fp8 quantization example. Model produced is uploaded here
TEST PLAN:
Tested locally.