[Bugfix] Fix keyword matching inconsistency in e2e tests #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srini-abhiram
requested review from
Xunzhuo,
rootfs and
wangchen615
as code owners
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
srini-abhiram
changed the title
…llm-project#713) Fixes two critical bugs causing keyword routing E2E test failures: 1. **Config merge bug**: Embedded struct assignment in reconciler didn't copy IntelligentRouting fields correctly. Changed to explicit field-by-field copy to ensure keyword rules are properly loaded from CRDs. 2. **Cache hit headers bug**: Cache responses used ImmediateResponse which bypassed normal header processing, causing VSR decision headers to be missing. Added vsrDecisionName parameter to CreateCacheHitResponse() to include x-vsr-selected-decision header in cached responses. **Test Results:** - keyword-routing: 16.67% -> 100% - rule-condition-logic: 33.33% -> 83.33% (remaining failure is unrelated) Fixes vllm-project#713 Signed-off-by: Srinivas A <56465971+srini-abhiram@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #713
-swhen doinggit commit[Bugfix],[Feat], and[CI].E2E tests revealed that keyword matching was highly unreliable:
Test Results
* The remaining failure is a domain classification ML model accuracy issue (physics query misclassified as psychology), which is unrelated to the keyword matching bug that was fixed.
Test Cases Now Passing
All keyword-based routing test cases now pass:
thinking_decisionthinking_decisionthinking_decisionthinking_decisionmath_decision(no keyword match)thinking_decision