Remove packet parsing logic out of PacketHandler#3225
Open
0blu wants to merge 1 commit intovmangos:developmentfrom
Open
Remove packet parsing logic out of PacketHandler#32250blu wants to merge 1 commit intovmangos:developmentfrom
0blu wants to merge 1 commit intovmangos:developmentfrom
Conversation
279cc45 to
efb0e5d
Compare
ratkosrb
reviewed
Mar 14, 2026
ratkosrb
reviewed
Mar 14, 2026
ratkosrb
reviewed
Mar 15, 2026
Contributor
|
Whats up with this new class SpellCastTargetsInfo, why do we need this? |
ratkosrb
reviewed
Mar 15, 2026
Collaborator
Author
The current SpellCastTargets is stateful, you need a reference the player. Which we might not have in the future when parsing will be handled in a different thread. |
ratkosrb
reviewed
Mar 17, 2026
ratkosrb
reviewed
Mar 18, 2026
22b83bc to
5564640
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR will remove the old packet parsing logic out of PacketHandlers (manual using
WorldPacket) and introduces new classes for each packet type.Notable example