Skip to content

Remove packet parsing logic out of PacketHandler#3225

Open
0blu wants to merge 1 commit intovmangos:developmentfrom
0blu:nice-packets
Open

Remove packet parsing logic out of PacketHandler#3225
0blu wants to merge 1 commit intovmangos:developmentfrom
0blu:nice-packets

Conversation

@0blu
Copy link
Collaborator

@0blu 0blu commented Feb 15, 2026

This MR will remove the old packet parsing logic out of PacketHandlers (manual using WorldPacket) and introduces new classes for each packet type.

Notable example

-        GetPlayer()->TeleportTo(mapId, positionX, positionY, positionZ, orientation);
+        GetPlayer()->TeleportTo(packet.location);
  • Test build of all supported client builds

@0blu 0blu force-pushed the nice-packets branch 2 times, most recently from 279cc45 to efb0e5d Compare February 21, 2026 20:58

This comment was marked as resolved.

@ratkosrb
Copy link
Contributor

Whats up with this new class SpellCastTargetsInfo, why do we need this?

@0blu
Copy link
Collaborator Author

0blu commented Mar 16, 2026

Whats up with this new class SpellCastTargetsInfo, why do we need this?

The current SpellCastTargets is stateful, you need a reference the player.

Which we might not have in the future when parsing will be handled in a different thread.

@0blu 0blu changed the title WIP: Remove packet parsing logic out of PacketHandler Remove packet parsing logic out of PacketHandler Mar 16, 2026
@0blu 0blu requested a review from ratkosrb March 16, 2026 20:35
@0blu 0blu force-pushed the nice-packets branch 2 times, most recently from 22b83bc to 5564640 Compare March 19, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants