-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating VIB GitHub Action to Node.js 20 #169
Conversation
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
This reverts commit 98cba25.
@gdelgadot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
This reverts commit 98cba25. Signed-off-by: Gloria Delgado <gloriad@vmware.com>
@gdelgadot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
@gdelgadot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
@gdelgadot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
@gdelgadot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
@gdelgadot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
@gdelgadot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
@gdelgadot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It looks like there is a bug related to
node20
andJest
that was affecting the GitHub Action, so I had to update thecore.setFailed
calls following this solution. That's why there are more changes apart from theNodejs
version update