Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating VIB GitHub Action to Node.js 20 #169

Merged
merged 20 commits into from
Feb 8, 2024

Conversation

gdelgadot
Copy link
Contributor

@gdelgadot gdelgadot commented Jan 31, 2024

It looks like there is a bug related to node20 and Jest that was affecting the GitHub Action, so I had to update the core.setFailed calls following this solution. That's why there are more changes apart from the Nodejs version update

Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
@gdelgadot gdelgadot requested a review from mpermar February 2, 2024 09:21
@gdelgadot gdelgadot requested review from fevisera and removed request for mpermar February 2, 2024 09:43
Signed-off-by: Gloria Delgado <gloriad@vmware.com>
@vmwclabot
Copy link

@gdelgadot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

This reverts commit 98cba25.

Signed-off-by: Gloria Delgado <gloriad@vmware.com>
@vmwclabot
Copy link

@gdelgadot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Gloria Delgado <gloriad@vmware.com>
@vmwclabot
Copy link

@gdelgadot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Gloria Delgado <gloriad@vmware.com>
@vmwclabot
Copy link

@gdelgadot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Gloria Delgado <gloriad@vmware.com>
@vmwclabot
Copy link

@gdelgadot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Gloria Delgado <gloriad@vmware.com>
@vmwclabot
Copy link

@gdelgadot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Gloria Delgado <gloriad@vmware.com>
@vmwclabot
Copy link

@gdelgadot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Gloria Delgado <gloriad@vmware.com>
@vmwclabot
Copy link

@gdelgadot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Copy link

@fevisera fevisera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gdelgadot gdelgadot merged commit f325790 into main Feb 8, 2024
1 check passed
@gdelgadot gdelgadot deleted the update-vib-github-action-nodejs20 branch February 8, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants